consensus/parlia: improve performance of func IsSystemTransaction#2912
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Feb 25, 2025
buddh0:fix-perf-issue-before-prague
Merged
consensus/parlia: improve performance of func IsSystemTransaction#2912zzzckck merged 1 commit intobnb-chain:developfrom buddh0:fix-perf-issue-before-prague
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:fix-perf-issue-before-prague
Conversation
zlacfzy
previously approved these changes
Feb 24, 2025
emailtovamos
previously approved these changes
Feb 24, 2025
zlacfzy
approved these changes
Feb 25, 2025
zzzckck
approved these changes
Feb 25, 2025
This was referenced Feb 28, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
consensus/parlia: improve performance of func IsSystemTransaction
Rationale
when use v1.5.x to do benchmark before prague hardfork, strange things happen: the performance downgrades a lot.
Reason is that, when importing a block, for every txs, need to apply func
IsSystemTransaction.In func
IsSystemTransaction, usep.signerwhich is apragueSigner,but when getting
Senderfor txs, use signercancunSigner,different type of signers lead to cache missing.
so in this PR, avoid to get sender in
IsSystemTransactionwhen possible.Example
add an example CLI or API response...
Changes
Notable changes: