feat: wait miner finish the later multi-proposals when restarting the node;#2845
Merged
zzzckck merged 4 commits intobnb-chain:developfrom Jan 7, 2025
Merged
feat: wait miner finish the later multi-proposals when restarting the node;#2845zzzckck merged 4 commits intobnb-chain:developfrom
zzzckck merged 4 commits intobnb-chain:developfrom
Conversation
emailtovamos
reviewed
Jan 6, 2025
buddh0
reviewed
Jan 7, 2025
buddh0
reviewed
Jan 7, 2025
miner/worker.go
Outdated
| } | ||
|
|
||
| currentBlock := currentHeader.Number.Uint64() | ||
| waitSecs := (endBlock - currentBlock) * posa.BlockInterval() |
Contributor
There was a problem hiding this comment.
issue: endBlock - currentBlock?
Collaborator
There was a problem hiding this comment.
I think we can wait more time to avoid shutdown immediately after miner producing the end block for safety, maybe another 10 second?
zzzckck
reviewed
Jan 7, 2025
zzzckck
previously approved these changes
Jan 7, 2025
buddh0
reviewed
Jan 7, 2025
buddh0
reviewed
Jan 7, 2025
buddh0
approved these changes
Jan 7, 2025
zzzckck
approved these changes
Jan 7, 2025
This was referenced Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR aims to avoid validator being slashed when restarting the node, the node will propose multi blocks after enabling the #2482.
So the PR will wait for the multi-block proposals to be done to avoid the slashing when restarting, and the node will wait
MaxWaitProposalInSecs.The default value of
MaxWaitProposalInSecsis set to 30 seconds. Because the average restart time in mainnet is around 30s, so the node try to wait for the next multi-proposals to be done.Changes
Notable changes: