Revert "internal/ethapi: remove td field from block (#30386)"#2836
Merged
buddh0 merged 1 commit intobnb-chain:developfrom Jan 2, 2025
buddh0:add_block_td_back
Merged
Revert "internal/ethapi: remove td field from block (#30386)"#2836buddh0 merged 1 commit intobnb-chain:developfrom buddh0:add_block_td_back
buddh0 merged 1 commit intobnb-chain:developfrom
buddh0:add_block_td_back
Conversation
This reverts commit 40fd887.
zzzckck
approved these changes
Jan 2, 2025
galaio
approved these changes
Jan 2, 2025
This was referenced Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 40fd887.
Description
Revert "internal/ethapi: remove td field from block (#30386)"
Rationale
tdis not useful for ethereum EL, because the forkchoice is decide by CL.but bsc still need the field
tdvia rpc.Example
add an example CLI or API response...
Changes
Notable changes: