fix: update prunefreezer’s offset when pruneancient and the dataset has pruned block #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
previously approved these changes
Aug 20, 2024
|
need to improve the |
jingjunLi
force-pushed
the
fix-CanonicalHash
branch
from
217b64e
to
c407904
Compare
jingjunLi
changed the title
buddh0
approved these changes
Aug 21, 2024
zzzckck
approved these changes
Aug 21, 2024
This was referenced Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2642
Rationale
If the dataset has been pruned, when set
--pruneancientthe offset value of the freezer will be incorrect;Example
add an example CLI or API response...
Changes
Notable changes: