Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: not record zero hash beacon block root with Parlia engine #2621

Merged

Conversation

NathanBSC
Copy link
Contributor

Description

core: not record zero hash beacon block root

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft July 31, 2024 06:22
zzzckck
zzzckck previously approved these changes Jul 31, 2024
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BSC, beaconRoot is nil before Bohr hard fork, and empty after Bohr.

@NathanBSC NathanBSC force-pushed the return_immediately_beaconRoot_zero branch from f3615b0 to f215c44 Compare July 31, 2024 08:00
@NathanBSC NathanBSC force-pushed the return_immediately_beaconRoot_zero branch from f215c44 to 6009529 Compare July 31, 2024 08:17
@buddh0 buddh0 changed the title core: not record zero hash beacon block root core: not record zero hash beacon block root with Parlia engine Jul 31, 2024
@buddh0 buddh0 marked this pull request as ready for review July 31, 2024 08:37
@zzzckck zzzckck merged commit 9e34366 into bnb-chain:develop Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants