faucet: rate limit initial implementation #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
reviewed
Jul 22, 2024
MatusKysel
reviewed
Jul 22, 2024
MatusKysel
reviewed
Jul 22, 2024
MatusKysel
reviewed
Jul 22, 2024
MatusKysel
reviewed
Jul 25, 2024
MatusKysel
reviewed
Jul 25, 2024
cmd/faucet/faucet.go
Outdated
Comment on lines
294
to
295
| limiter := f.limiter.GetLimiter(ip) | ||
| if !limiter.Allow() { |
There was a problem hiding this comment.
as you are not using limiter maybe better approach will be to implement f.limiter.Allow(ip)
MatusKysel
previously approved these changes
Jul 25, 2024
zzzckck
reviewed
Jul 26, 2024
zzzckck
reviewed
Jul 26, 2024
cmd/faucet/rate_limiter.go
Outdated
| return i, nil | ||
| } | ||
|
|
||
| func (i *IPRateLimiter) AddIP(ip string) *rate.Limiter { |
There was a problem hiding this comment.
if AddIP is only for internal usage, we can name it: addIP
zzzckck
reviewed
Jul 26, 2024
cmd/faucet/rate_limiter.go
Outdated
| type IPRateLimiter struct { | ||
| ips *lru.Cache | ||
| r rate.Limit | ||
| b int |
There was a problem hiding this comment.
better to add some comments for b, it is the burst value within 5min?
zzzckck
reviewed
Jul 26, 2024
zzzckck
reviewed
Jul 26, 2024
zzzckck
approved these changes
Jul 26, 2024
MatusKysel
approved these changes
Jul 26, 2024
This was referenced Aug 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some rate limiting for faucet.
Also couple of concurrencies being introduced so that the main loop doesn't potentially get stuck in one single request.
Addressing issue: #2606
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: