Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: improve the network stability when double sign happens #2596

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Jul 19, 2024

Description

core: improve the network stability when double sign happens

Rationale

for example, 3 validator(vb, vc, vd) do an double sign attack together,
they can easily spilt the network into 8 subnets, then the whole chain stops

image

to solve this issue, we should give a definited rule to select forks.

in additon, this change is back compatible

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as ready for review July 19, 2024 03:11
@buddh0 buddh0 requested a review from brilliant-lx July 22, 2024 01:46
@zzzckck
Copy link
Collaborator

zzzckck commented Jul 22, 2024

I think we can improve this expression later, to make it easier to read.

@zzzckck zzzckck merged commit b844958 into bnb-chain:develop Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants