fix: the bug of blobsidecars and downloader with multi-database #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
changed the title
buddh0
previously approved these changes
Jul 10, 2024
jingjunLi
force-pushed
the
fix-multidatabase-sidebars
branch
2 times, most recently
from
62ee8af
to
0aafc91
Compare
RenRick
previously approved these changes
Jul 16, 2024
core/rawdb/accessors_chain.go
Outdated
| @@ -34,6 +34,15 @@ import ( | |||
| "golang.org/x/exp/slices" | |||
| ) | |||
|
|
|||
| // In BEP-365: Support Multi-Database Based on Data Pattern, the Chaindata will be divided into three stores: BlockStore, TrieStore, and Others, | |||
There was a problem hiding this comment.
Multi-Database is not a BEP, pls delete "In BEP-365:"
jingjunLi
force-pushed
the
fix-multidatabase-sidebars
branch
from
7cf1cb0
to
44decdf
Compare
jingjunLi
changed the title
zzzckck
reviewed
Jul 16, 2024
core/rawdb/accessors_chain.go
Outdated
| @@ -34,6 +34,15 @@ import ( | |||
| "golang.org/x/exp/slices" | |||
| ) | |||
|
|
|||
| // Support Multi-Database Based on Data Pattern, the Chaindata will be divided into three stores: BlockStore, TrieStore, and Others, | |||
There was a problem hiding this comment.
TrieStore -> StateStore?
Others -> ChainStore?
zzzckck
reviewed
Jul 16, 2024
zzzckck
previously approved these changes
Jul 16, 2024
zzzckck
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
Merged
flywukong
added a commit
to flywukong/bsc
that referenced
this pull request
Jul 23, 2024
…se (bnb-chain#2564)" This reverts commit 87e622e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: some bugs for multi-database
Description
Rationale
Issue:
Improvement:
MultiDatabaseReaderinterface. This allows reading meta interfaces without specifying blockStore, while Write/Delete related interfaces still require it.Example
add an example CLI or API response...
Changes
Notable changes: