Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waiting for the last simulation before pick best bid #2507

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

irrun
Copy link
Contributor

@irrun irrun commented Jun 6, 2024

Description

fix: waiting for the last simulation before pick best bid

Rationale

The final round of bid simulation is often interrupted by stopTimer and not fully packed, making it less competitive than local miner and degrading the mev experience.

So we take two steps to optimize it:

  1. do not set a stop timer when the bid is packaged;
  2. when the local miner fetches the best bid, wait a while for the bid that is being packaged at the time to finish job.

This is a short-term solution. It will be addressed in the long run with a more formal fix and be put into the next stable release.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

miner/bid_simulator.go Outdated Show resolved Hide resolved
miner/bid_simulator.go Outdated Show resolved Hide resolved
miner/worker.go Outdated Show resolved Hide resolved
miner/worker.go Outdated Show resolved Hide resolved
@irrun irrun force-pushed the i/mevfix branch 2 times, most recently from 2aa97c2 to 2195772 Compare June 6, 2024 08:02
@unclezoro unclezoro merged commit af7e9b9 into bnb-chain:develop Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants