fix: fix inspect database error #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When executing inspect, an error in judgment causes block data to be repeatedly traversed, resulting in a large amount of data being marked as unaccounted.
Rationale
In Go, directly comparing two interface values for equality is generally unsafe, especially for complex types like the database interface ethdb.Database. This is because interface comparison checks not only their values but also whether their dynamic types match.
Add the
HasSeparateBlockStoreinterface to indicate whether a separate block store is enabled.Example
add an example CLI or API response...
Changes
Notable changes: