core/vm: add secp256r1 into PrecompiledContractsHaber #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
force-pushed
the
secp256r1_add_haber_logic
branch
from
c633c02
to
ea8e830
Compare
zzzckck
previously approved these changes
May 21, 2024
galaio
previously approved these changes
May 21, 2024
MatusKysel
previously approved these changes
May 21, 2024
NathanBSC
dismissed stale reviews from MatusKysel, galaio, and zzzckck
via
f696042
galaio
previously approved these changes
May 21, 2024
zzzckck
previously approved these changes
May 21, 2024
galaio
approved these changes
May 21, 2024
zzzckck
approved these changes
May 21, 2024
brilliant-lx
approved these changes
May 21, 2024
MatusKysel
approved these changes
May 21, 2024
emailtovamos
approved these changes
May 21, 2024
|
There's nothing named |
MatusKysel
reviewed
May 21, 2024
| common.BytesToAddress([]byte{104}): &verifyDoubleSignEvidence{}, | ||
| common.BytesToAddress([]byte{105}): &secp256k1SignatureRecover{}, | ||
|
|
||
| common.BytesToAddress([]byte{0x01, 0x00}): &p256Verify{}, |
There was a problem hiding this comment.
@emailtovamos P256 (a.k.a. secp256r1 elliptic curve)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core/vm: add secp256r1 into PrecompiledContractsHaber
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: