Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: ensure consistency in BPS bundle result #2479

Merged
merged 2 commits into from
May 21, 2024
Merged

dev: ensure consistency in BPS bundle result #2479

merged 2 commits into from
May 21, 2024

Conversation

Jolly23
Copy link
Contributor

@Jolly23 Jolly23 commented May 20, 2024

Description

This commit introduces a NonRevertible hash list within the RPC to address potential inconsistencies between the builder and validator during bundle operations. The builder sends a list of transaction hashes, which must be successfully executed, to the validator. If the validator cannot accurately execute the bundle, it refrains from packing that block. This mechanism ensures that both components maintain output consistency under the same input conditions, thereby preventing financial losses for searchers due to incorrect block inclusion.

Rationale

This happened on BloxRoute builder before. The simulation runs fine on builder but one transaction in bundle somehow couldn't pass on validator, which costs searcher $$$$$

Example

The builder sends the list of hashes from bundle txs that is no-revertible, to ensure the validator runs the MEV bundles right.

Changes

Notable changes:

  • builder SendBid with NonRevertible

@unclezoro unclezoro changed the base branch from master to develop May 20, 2024 05:30
core/types/bid.go Outdated Show resolved Hide resolved
miner/bid_simulator.go Outdated Show resolved Hide resolved
miner/bid_simulator.go Outdated Show resolved Hide resolved
@unclezoro
Copy link
Collaborator

Please rebase the code to develop branch.

@Jolly23 Jolly23 closed this May 20, 2024
@Jolly23 Jolly23 deleted the dev-BPS branch May 20, 2024 10:10
@Jolly23 Jolly23 restored the dev-BPS branch May 20, 2024 10:13
@Jolly23 Jolly23 reopened this May 20, 2024
@unclezoro unclezoro merged commit 08769ea into bnb-chain:develop May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants