Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recommit bid when newBidCh is empty to maximize mev reward #2424

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

irrun
Copy link
Contributor

@irrun irrun commented Apr 25, 2024

Description

recommit bid when newBidCh is empty to maximize mev reward

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@irrun irrun requested a review from zzzckck as a code owner April 25, 2024 07:31
pythonberg1997
pythonberg1997 previously approved these changes Apr 26, 2024
unclezoro
unclezoro previously approved these changes Apr 26, 2024
@@ -649,7 +656,7 @@ func (b *bidSimulator) simBid(interruptCh chan int32, bidRuntime *BidRuntime) {
}

// this is the simplest strategy: best for all the delegators.
if bidRuntime.packedBlockReward.Cmp(bestBid.packedBlockReward) > 0 {
if bidRuntime.packedBlockReward.Cmp(bestBid.packedBlockReward) >= 0 {
b.SetBestBid(bidRuntime.bid.ParentHash, bidRuntime)
success = true
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need send the best bid back to channel

miner/bid_simulator.go Outdated Show resolved Hide resolved
@irrun irrun dismissed stale reviews from unclezoro and pythonberg1997 via c1bfada April 26, 2024 08:37
zzzckck
zzzckck previously approved these changes Apr 26, 2024
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more changes

@zzzckck zzzckck merged commit ba67263 into bnb-chain:develop Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants