cmd, p2p: filter peers by regex on name

[weiihann]

Description

This PR adds a new feature to filter peers by their names based on a set of customized regex patterns.

Rationale

Some outdated versions of nodes running on BSC may keep connecting to a healthy set of peers and only consume information, but not return any useful data. Such nodes should be filtered out to save network bandwidth.

Example

In the config file:

...
[Node.P2P]
PeerFilterPatterns = ["(?!)geth"]
...

An example of a false regexp pattern error message:

t=2024-04-18T06:02:10+0000 lvl=error msg="Failed to compile peer filter patterns" err="error parsing regexp: missing closing ): `abc(def`"

[wellgamer789]

"may keep connecting to a healthy set of peers and only consume information, but not return any useful data."

I may be wrong, but i think what you are fighting are "fake nodes" and they can easily bypass this "check".

[zzzckck]

"may keep connecting to a healthy set of peers and only consume information, but not return any useful data."

I may be wrong, but i think what you are fighting are "fake nodes" and they can easily bypass this "check".

yes, it is just optional feature, can not solve the case you mentioned. But could be useful in some cases.

[kaber2]

Obsolete peers should be filtered based on the fork ID. This seems really useless.

[zzzckck]

1.to filter out specified nodes that the name contains "alice"

[Node.P2P]
PeerFilterPatterns = ["^alice.*"]

This will reject connection from client with name "alice*"

2.to filter out specified nodes that the name contains either "alice" or "bob"

[Node.P2P]
PeerFilterPatterns = ["^alice.*|^bob.*"]

3.Some Examples

[Node.P2P]
PeerFilterPatterns = ["Geth/v1.3.*|Geth/v1.4.4.*|Geth/v1.4.5.*|Geth/v1.4.6.*"]

[setunapo]

https://www.jyshare.com/front-end/854/?optionGlobl=global