core: stateDb has no trie and no snap return err #2369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check to
Blockchain.StateAt()
such that if the node is a fast node (i.e. NoTrie = true) and the snap layer cannot be found, then it will return an error.Rationale
Refer to #2331.
By default, a fast node will have an empty trie for any state. Retrieving a value from an empty trie will give
0x00...00
. It may be confusing for users as0x00...00
could also be the actual value. Hence, it's more useful to throw an error when the state is not available.Example
Command
Output
Changes
StateDB.GetSnap()