Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: improve chain rewinding mechanism #2334

Merged
merged 2 commits into from
Apr 1, 2024
Merged

core: improve chain rewinding mechanism #2334

merged 2 commits into from
Apr 1, 2024

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented Mar 26, 2024 •
edited
Loading

Description

This pull request improves the chain rewinding mechanism a bit:

  • use a more efficient approach for finding an available state in path scheme
  • set a rewinding limit in hash scheme for preventing endless rewinding if the snapshot is above the head.

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • N/A

@sysvm sysvm changed the base branch from master to develop March 26, 2024 02:29
@sysvm sysvm force-pushed the fix-headstate branch 4 times, most recently from 576f337 to a6bbbe9 Compare March 27, 2024 03:20
@sysvm sysvm requested a review from unclezoro as a code owner March 27, 2024 14:36
@sysvm sysvm added the r4r ready for review label Mar 28, 2024
@zzzckck zzzckck merged commit 212b7a6 into bnb-chain:develop Apr 1, 2024
7 checks passed
This was referenced Apr 2, 2024
Merged
Merged
@sysvm sysvm deleted the fix-headstate branch May 28, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@fynnss fynnss fynnss approved these changes

@joeylichang joeylichang joeylichang approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

Assignees
No one assigned
Labels
r4r ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sysvm @joeylichang @fynnss @zzzckck @rjl493456442