Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port cancun related changes from unreleased v1.4.0 #2311

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Mar 20, 2024

Description

Port cancun related changes from unreleased v1.4.0

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft March 20, 2024 08:46
zzzckck
zzzckck previously approved these changes Mar 20, 2024
@buddh0 buddh0 force-pushed the port_cancun_related_changes_from_unreleased_v1.4.0 branch from 7281256 to 5932061 Compare March 20, 2024 08:52
@buddh0
Copy link
Collaborator Author

buddh0 commented Mar 20, 2024

[crypto/kz4844: pass blobs by ref (https://github.com/ethereum/go-ethereum/pull/29050)](ethereum/go-ethereum#29050)
is not ported now, because it need update version of prysm
we may port it after blobtx branch merged

@buddh0 buddh0 marked this pull request as ready for review March 20, 2024 09:12
s1na and others added 7 commits March 20, 2024 19:21
* eth/catalyst: update simulated beacon for cancun

* validate blob hashes

* compute hashes from commitment

* fix beacon root and payload version

* check commitment conversion

* fix random attr

* flip dev to cancun
* internal/jsre: format receipt.{blobGasPrice,blobGasUsed} to int

Signed-off-by: jsvisa <[email protected]>

* internal/jsre: format tx.maxFeePerBlobGas to int

Signed-off-by: jsvisa <[email protected]>

* internal/jsre: format blob* in block

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
* eth/tracers: prestate balance add blob fee

Signed-off-by: jsvisa <[email protected]>

* eth/tracers: prestate test support blob tx

Signed-off-by: jsvisa <[email protected]>

* eth/tracers: add prestate blob tx test

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
fix(t8n): unexpected `excessBlobGas` shadowed
In https://eips.ethereum.org/EIPS/eip-4788 the name `BEACON_ROOTS_ADDRESS` is used. This change makes geth use the same variable name to avoid confusion.
@buddh0 buddh0 force-pushed the port_cancun_related_changes_from_unreleased_v1.4.0 branch from 5932061 to 66ed85e Compare March 20, 2024 11:27
@zzzckck zzzckck merged commit ebe88c0 into bnb-chain:develop Mar 20, 2024
6 of 7 checks passed
@Pjrich1313 Pjrich1313 mentioned this pull request Mar 27, 2024
Copy link

@Pjrich1313 Pjrich1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O

Copy link

@Pjrich1313 Pjrich1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.