Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add FeynmanFix upgrade for a testnet issue #2288

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

pythonberg1997
Copy link
Contributor

@pythonberg1997 pythonberg1997 commented Mar 14, 2024

Description

This pr is to add FeynmanFix upgrade.

Rationale

There's one issue within the StakeHub system contract. This pr is to add a new hardfork to upgrade the contract code.

For more info about the contract issue, please refer to bnb-chain/bsc-genesis-contract#523

Example

add an example CLI or API response...

Changes

Notable changes:

  • add FeynmanFix upgrade

@pythonberg1997 pythonberg1997 changed the base branch from release_v1.3.10_fix to v1.3.10_base March 14, 2024 10:45
params/config.go Outdated Show resolved Hide resolved
@buddh0
Copy link
Collaborator

buddh0 commented Mar 18, 2024

not support flag? maybe align with flag OverrideFeynman is better

params/config.go Outdated
ShanghaiTime *uint64 `json:"shanghaiTime,omitempty"` // Shanghai switch time (nil = no fork, 0 = already on shanghai)
KeplerTime *uint64 `json:"keplerTime,omitempty"` // Kepler switch time (nil = no fork, 0 = already activated)
FeynmanTime *uint64 `json:"feynmanTime,omitempty"` // Feynman switch time (nil = no fork, 0 = already activated)
FeynmanFixTime *uint64 `json:"feynmanFixTime,omitempty"` // Feynman switch time (nil = no fork, 0 = already activated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comment Feynman switch time

@unclezoro unclezoro merged commit 9fb0241 into bnb-chain:v1.3.10_base Mar 18, 2024
1 check failed
weiihann pushed a commit to weiihann/bsc that referenced this pull request Mar 18, 2024
@pythonberg1997 pythonberg1997 deleted the bc-fusion-1.3.10-fix branch April 11, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants