Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: render system bytecode by go:embed #2201

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Feb 2, 2024

Description

render system bytecode by go:embed

no impact on the system.

Rationale

As the system is upgraded, more and more upgrade.go files are expanding, making it difficult to open and review the code.

Use go:embed instead to render bytecode into the binary during compilation, which will reduce the difficulty of code maintenance in the future.

Example

n/a

Changes

Notable changes:

  • systemcontracrs

@j75689 j75689 changed the base branch from bc-fusion to develop February 2, 2024 09:37
@j75689 j75689 force-pushed the bc-fusion-render-bytecode-by-files branch 2 times, most recently from 08a09f7 to ae5d08b Compare February 2, 2024 09:44
@zzzckck
Copy link
Collaborator

zzzckck commented Feb 5, 2024

could include this PR after #2200

@j75689 j75689 marked this pull request as draft February 5, 2024 08:34
@j75689 j75689 force-pushed the bc-fusion-render-bytecode-by-files branch from ae5d08b to 7e6ae62 Compare April 12, 2024 07:13
@j75689 j75689 marked this pull request as ready for review April 12, 2024 07:13
@j75689 j75689 requested a review from zzzckck as a code owner April 12, 2024 07:13
@j75689
Copy link
Contributor Author

j75689 commented Apr 12, 2024

The code was generated by this tool -> https://github.com/j75689/bsc-bytecode-extraction-tool

setunapo

This comment was marked as off-topic.

Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the byte code of mainnet is ok.
Will run full sync for testnet/mainnet and approve this PR sync passed, could take 2 weeks.

@buddh0
Copy link
Collaborator

buddh0 commented Apr 12, 2024

just ensure that hash of all codes not change after this PR
run the UT on develop branch and this PR based branch, both will pass

Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait

@zzzckck zzzckck merged commit 11503ed into bnb-chain:develop Apr 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants