core: use finalized block as the chain freeze indicator #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingjunLi
force-pushed
the
improve-chain-freezer
branch
from
9713c67
to
7c87fe6
Compare
jingjunLi
force-pushed
the
improve-chain-freezer
branch
from
7c87fe6
to
a3ee014
Compare
|
Change the Currently it's 1min and will generate 20 blocks during the interval, plus 2-3 un-finalized blocks. |
fixed |
jingjunLi
force-pushed
the
improve-chain-freezer
branch
from
0a7c703
to
47dcbdc
Compare
|
Merge it to #2227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request uses the finalized block tag as the indicator for chain freezing.
Originally, the latest 90K blocks will be retained in the key-value store by default, which are regarded as "non-finalized" in the context of Proof-of-work. However, in Proof-of-stake, we do have the concrete finalized block tag from the consensus client. Therefore, it makes more sense to directly rely on the Finalized for chain freezing.
Rationale
By deploying it on a full node, we can see there are only 23 blocks left in the key-value store.
Example
add an example CLI or API response...
Changes
Notable changes: