Fix some flaky tests #1379

ngotchac · 2023-03-22T08:51:34Z

Description

It happens quite frequently to see this kind of panics in certain tests:

panic: block 670: invalid merkle root (remote: 8c794c3300407cdd8c96561d0349bc058978fd797998e4148f0c8414148655c6 local: efd72b1ee5be3e5905a0362f54a678ead61fe2a6baf4def407d3d2bfba340bf0)

goroutine 2182788 [running]:
github.com/ethereum/go-ethereum/eth/downloader.newTestBlockchain.func1()
	/.../bsc/eth/downloader/testchain_test.go:222 +0x37a

It traced it back to this PR: #1006

It seems that the reset of prefetcher in StopPrefetcher() should have never been removed, as pointed out by @brilliant-lx in their comment https://github.com/bnb-chain/bsc/pull/1006/files#r947376180

Rationale

The tests no longer panic. I manager to trigger the error (almost) every time with this command:

seq 1 10 | parallel go test -count=1 ./eth/downloader -run "TestCanonicalSynchronisation66Full" -v

ngotchac · 2023-03-22T11:34:22Z

I added 2 new commits for 2 other test fixes:

TestLargeReorgTrieGC in core: triedb.Dereference in writeBlockWithState was started in a go-routine without any syncrhonisation.

To replicate failure:

seq 1 10 | parallel go test -count=10 ./core -run "TestLargeReorgTrieGC" -failfast

TestGetDiffLayers in eth/protocols/diff : there was an index mismatch in the test cases if one of the random number generated was 0

To replicate failure:

seq 1 16 | parallel go test -count=10 ./eth/protocols/diff -run "TestGetDiffLayers" -failfast

galaio · 2023-03-31T08:38:57Z

Very appreciate your contribution, we are checking on it. And you may fix it based on develop branch, there are also some fixes in the develop branch that help you to pass the CI.

By the way, I cannot reproduce the TestGetDiffLayers failure, it works in the current develop branch;
env: MacOS, go 1.19.7
commitId: af7f0dd;

core/blockchain.go

core/state/statedb.go

qinglin89 · 2023-04-02T07:42:26Z

The ut fail of invalid merkle tree under 66Full is ethash related, and parlia doesn't have this issue.
Might change the ut to use consensus engine with parlia since some consensus logic implemented by parlia had been different with ethash

ngotchac · 2023-04-03T07:18:24Z

I just rebased my branch of develop, and can confirm that it still does fix those tests (which don't pass on develop but do on my branch):

seq 1 10 | parallel go test -count=1 ./eth/downloader -run "TestCanonicalSynchronisation66Full" -v
seq 1 10 | parallel go test -count=10 ./core -run "TestLargeReorgTrieGC" -failfast
seq 1 16 | parallel go test -count=10 ./eth/protocols/diff -run "TestGetDiffLayers" -failfast

Not that I have to use parallel testing to trigger the failures, and the parameters might differ from machine to machine.

galaio · 2023-04-03T07:25:18Z

I just rebased my branch of develop, and can confirm that it still does fix those tests (which don't pass on develop but do on my branch):

seq 1 10 | parallel go test -count=1 ./eth/downloader -run "TestCanonicalSynchronisation66Full" -v

seq 1 10 | parallel go test -count=10 ./core -run "TestLargeReorgTrieGC" -failfast

seq 1 16 | parallel go test -count=10 ./eth/protocols/diff -run "TestGetDiffLayers" -failfast

Not that I have to use parallel testing to trigger the failures, and the parameters might differ from machine to machine.

Could you attach the failure reason of TestGetDiffLayers?

ngotchac · 2023-04-03T07:38:32Z

Could you attach the failure reason of TestGetDiffLayers?

Sure!

Output

--- FAIL: TestGetDiffLayers (1.53s)
    handler_test.go:166: test 71: diff layer mismatch: message payload mismatch:
        got:  f87a47f877f875a0b75219eabc7beb20b3d801f3727679bdd599eceb8cf296323053ec07419f1b3082073ec6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082073e8080e69471562b71999873db5b286df957af199ec94617f790cf82073e89c9043910bef3401e428080c0
        want: f87a48f877f875a0b75219eabc7beb20b3d801f3727679bdd599eceb8cf296323053ec07419f1b3082073ec6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082073e8080e69471562b71999873db5b286df957af199ec94617f790cf82073e89c9043910bef3401e428080c0
    handler_test.go:166: test 72: diff layer mismatch: message payload mismatch:
        got:  f87a48f877f875a00b0d030ac8dc89e66c78a4c1c7f7fae1432fc9194b7ab20d69bbdaf625cf6e6182076ec6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082076e8080e69471562b71999873db5b286df957af199ec94617f790cf82076e89ce387d941db84512128080c0
        want: f87a49f877f875a00b0d030ac8dc89e66c78a4c1c7f7fae1432fc9194b7ab20d69bbdaf625cf6e6182076ec6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082076e8080e69471562b71999873db5b286df957af199ec94617f790cf82076e89ce387d941db84512128080c0
    handler_test.go:166: test 73: diff layer mismatch: message payload mismatch:
        got:  f87a49f877f875a023b0813b1453a37d0bd8502fc2ad7bc0ff93a6c4033ca67345c7367b616de37f820507c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205078080e69471562b71999873db5b286df957af199ec94617f790cf820507898b8acfc0ef7bf59e398080c0
        want: f87a4af877f875a023b0813b1453a37d0bd8502fc2ad7bc0ff93a6c4033ca67345c7367b616de37f820507c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205078080e69471562b71999873db5b286df957af199ec94617f790cf820507898b8acfc0ef7bf59e398080c0
    handler_test.go:166: test 74: diff layer mismatch: message payload mismatch:
        got:  f87a4af877f875a0024c054f8124f862f4f2e3299a95817fe14c2e27af4a7ac8e740298a5ff7c6808207bdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207bd8080e69471562b71999873db5b286df957af199ec94617f790cf8207bd89d6c92e56ff07328e038080c0
        want: f87a4bf877f875a0024c054f8124f862f4f2e3299a95817fe14c2e27af4a7ac8e740298a5ff7c6808207bdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207bd8080e69471562b71999873db5b286df957af199ec94617f790cf8207bd89d6c92e56ff07328e038080c0
    handler_test.go:166: test 75: diff layer mismatch: message payload mismatch:
        got:  f87a4bf877f875a014eb0ad44e28c3fb511c90015a3a5bf97b9fbd0fd9a57a046e02d6dd013e901482059fc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082059f8080e69471562b71999873db5b286df957af199ec94617f790cf82059f899c05a8b646412ff7a18080c0
        want: f87a4cf877f875a014eb0ad44e28c3fb511c90015a3a5bf97b9fbd0fd9a57a046e02d6dd013e901482059fc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082059f8080e69471562b71999873db5b286df957af199ec94617f790cf82059f899c05a8b646412ff7a18080c0
    handler_test.go:166: test 76: diff layer mismatch: message payload mismatch:
        got:  f87a4cf877f875a0f7dcfcb58d5b7d9e448cb075c1a93635e528bfcbcb1079da22da1b178b3a21748206f2c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206f28080e69471562b71999873db5b286df957af199ec94617f790cf8206f289c0c6cc961390a2f18e8080c0
        want: f87a4df877f875a0f7dcfcb58d5b7d9e448cb075c1a93635e528bfcbcb1079da22da1b178b3a21748206f2c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206f28080e69471562b71999873db5b286df957af199ec94617f790cf8206f289c0c6cc961390a2f18e8080c0
    handler_test.go:166: test 77: diff layer mismatch: message payload mismatch:
        got:  f87a4df877f875a08ae16e2a672c63ea2b25e207f79c9b9aa988d9dac40f2ea176132e82ac5becb78206e6c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206e68080e69471562b71999873db5b286df957af199ec94617f790cf8206e689bf79bb753bdf61b49a8080c0
        want: f87a4ef877f875a08ae16e2a672c63ea2b25e207f79c9b9aa988d9dac40f2ea176132e82ac5becb78206e6c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206e68080e69471562b71999873db5b286df957af199ec94617f790cf8206e689bf79bb753bdf61b49a8080c0
    handler_test.go:166: test 78: diff layer mismatch: message payload mismatch:
        got:  f87a4ef877f875a090424e7f3fa440f9e8bbf761bc1af8bf5dfa678c3c4d9b60b448a977c3d0a9e38204fdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204fd8080e69471562b71999873db5b286df957af199ec94617f790cf8204fd898a75417ae6683f40c38080c0
        want: f87a4ff877f875a090424e7f3fa440f9e8bbf761bc1af8bf5dfa678c3c4d9b60b448a977c3d0a9e38204fdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204fd8080e69471562b71999873db5b286df957af199ec94617f790cf8204fd898a75417ae6683f40c38080c0
    handler_test.go:166: test 79: diff layer mismatch: message payload mismatch:
        got:  f87a4ff877f875a0640fbab6259e44a7c60ed19089fad504ac86e537e2cdaace0427bdcbd1d3ff84820648c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206488080e69471562b71999873db5b286df957af199ec94617f790cf82064889ae5859ef794186bcb88080c0
        want: f87a50f877f875a0640fbab6259e44a7c60ed19089fad504ac86e537e2cdaace0427bdcbd1d3ff84820648c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206488080e69471562b71999873db5b286df957af199ec94617f790cf82064889ae5859ef794186bcb88080c0
    handler_test.go:166: test 80: diff layer mismatch: message payload mismatch:
        got:  f87a50f877f875a048892f486ee5804759d9ce2ecfbd6e0d318542c9a45663c27a2dc3254d2a94be8206ebc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206eb8080e69471562b71999873db5b286df957af199ec94617f790cf8206eb89c004829840693ce3558080c0
        want: f87a51f877f875a048892f486ee5804759d9ce2ecfbd6e0d318542c9a45663c27a2dc3254d2a94be8206ebc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206eb8080e69471562b71999873db5b286df957af199ec94617f790cf8206eb89c004829840693ce3558080c0
    handler_test.go:166: test 81: diff layer mismatch: message payload mismatch:
        got:  f87a51f877f875a00a5faaf1f2de9cd168871dcf72b36301a2d2c03aee42277756ea6592268925de8207cdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207cd8080e69471562b71999873db5b286df957af199ec94617f790cf8207cd89d885452d73f38989f38080c0
        want: f87a52f877f875a00a5faaf1f2de9cd168871dcf72b36301a2d2c03aee42277756ea6592268925de8207cdc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207cd8080e69471562b71999873db5b286df957af199ec94617f790cf8207cd89d885452d73f38989f38080c0
    handler_test.go:166: test 82: diff layer mismatch: message payload mismatch:
        got:  f87a52f877f875a02d712295b2bcb5eebf17bbd3e67cc2c2d90e215708437d3801ca5d712d98cdaf820526c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205268080e69471562b71999873db5b286df957af199ec94617f790cf820526898ee73c007205de265a8080c0
        want: f87a53f877f875a02d712295b2bcb5eebf17bbd3e67cc2c2d90e215708437d3801ca5d712d98cdaf820526c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205268080e69471562b71999873db5b286df957af199ec94617f790cf820526898ee73c007205de265a8080c0
    handler_test.go:166: test 83: diff layer mismatch: message payload mismatch:
        got:  f87a53f877f875a0233e83111e0f12df0b9bb7e616d4ddf58b80e33654c1510788c4709176d7ec99820417c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204178080e69471562b71999873db5b286df957af199ec94617f790cf820417897185793015a2dcdb298080c0
        want: f87a54f877f875a0233e83111e0f12df0b9bb7e616d4ddf58b80e33654c1510788c4709176d7ec99820417c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204178080e69471562b71999873db5b286df957af199ec94617f790cf820417897185793015a2dcdb298080c0
    handler_test.go:166: test 84: diff layer mismatch: message payload mismatch:
        got:  f87a54f877f875a019f6603add653386821e28c554f94974b9d72f910f15d9c562a89f3a53ff326682052dc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082052d8080e69471562b71999873db5b286df957af199ec94617f790cf82052d898fa985fe452d4434938080c0
        want: f87a55f877f875a019f6603add653386821e28c554f94974b9d72f910f15d9c562a89f3a53ff326682052dc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082052d8080e69471562b71999873db5b286df957af199ec94617f790cf82052d898fa985fe452d4434938080c0
    handler_test.go:166: test 85: diff layer mismatch: message payload mismatch:
        got:  f87a55f877f875a0fb39f01bbeeee197922dde9ffa48da2d7607a1083f0c49f6bcfc850eb29f056382052bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082052b8080e69471562b71999873db5b286df957af199ec94617f790cf82052b898f720323768fb955158080c0
        want: f87a56f877f875a0fb39f01bbeeee197922dde9ffa48da2d7607a1083f0c49f6bcfc850eb29f056382052bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082052b8080e69471562b71999873db5b286df957af199ec94617f790cf82052b898f720323768fb955158080c0
    handler_test.go:166: test 86: diff layer mismatch: message payload mismatch:
        got:  f87a56f877f875a0c51b9469f746279a45b147af770e14f4e93d146c7ace173a45d68f5381077c438204dac6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204da8080e69471562b71999873db5b286df957af199ec94617f790cf8204da8986a9cf85c6a340f9a68080c0
        want: f87a57f877f875a0c51b9469f746279a45b147af770e14f4e93d146c7ace173a45d68f5381077c438204dac6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204da8080e69471562b71999873db5b286df957af199ec94617f790cf8204da8986a9cf85c6a340f9a68080c0
    handler_test.go:166: test 87: diff layer mismatch: message payload mismatch:
        got:  f87a57f877f875a0e077ce4c3c49931c1dcc1d1c88a8d766cb12aac01f57f27869f2088827a82444820623c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206238080e69471562b71999873db5b286df957af199ec94617f790cf82062389aa55651f8adefd961d8080c0
        want: f87a58f877f875a0e077ce4c3c49931c1dcc1d1c88a8d766cb12aac01f57f27869f2088827a82444820623c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206238080e69471562b71999873db5b286df957af199ec94617f790cf82062389aa55651f8adefd961d8080c0
    handler_test.go:166: test 88: diff layer mismatch: message payload mismatch:
        got:  f87a58f877f875a0260b3921f3028c33ff9c01cefe10da51636e677760f0a6e867585d360221bf4f8207efc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207ef8080e69471562b71999873db5b286df957af199ec94617f790cf8207ef89dc34f5b52c69c261518080c0
        want: f87a59f877f875a0260b3921f3028c33ff9c01cefe10da51636e677760f0a6e867585d360221bf4f8207efc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207ef8080e69471562b71999873db5b286df957af199ec94617f790cf8207ef89dc34f5b52c69c261518080c0
    handler_test.go:166: test 89: diff layer mismatch: message payload mismatch:
        got:  f87a59f877f875a08dc395aded937bacd332e7355abe25841ea2d6546ba6b941eaf3a188d4f91bbf820475c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204758080e69471562b71999873db5b286df957af199ec94617f790cf820475897bb67f5c048f5be34b8080c0
        want: f87a5af877f875a08dc395aded937bacd332e7355abe25841ea2d6546ba6b941eaf3a188d4f91bbf820475c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204758080e69471562b71999873db5b286df957af199ec94617f790cf820475897bb67f5c048f5be34b8080c0
    handler_test.go:166: test 90: diff layer mismatch: message payload mismatch:
        got:  f87a5af877f875a02d7c1a2fe5ad5ecee78a4d47975b89a20c017484276ec71ad1508185b23405ef820583c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205838080e69471562b71999873db5b286df957af199ec94617f790cf8205838998fc80bef9a397bebd8080c0
        want: f87a5bf877f875a02d7c1a2fe5ad5ecee78a4d47975b89a20c017484276ec71ad1508185b23405ef820583c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808205838080e69471562b71999873db5b286df957af199ec94617f790cf8205838998fc80bef9a397bebd8080c0
    handler_test.go:166: test 91: diff layer mismatch: message payload mismatch:
        got:  f87a5bf877f875a04139c32fc7fead5f4c471af8dcd948fdddc5412dc5087a84e44050af0ba2cf7b82060cc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082060c8080e69471562b71999873db5b286df957af199ec94617f790cf82060c89a7d7044b42cb408bf48080c0
        want: f87a5cf877f875a04139c32fc7fead5f4c471af8dcd948fdddc5412dc5087a84e44050af0ba2cf7b82060cc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082060c8080e69471562b71999873db5b286df957af199ec94617f790cf82060c89a7d7044b42cb408bf48080c0
    handler_test.go:166: test 92: diff layer mismatch: message payload mismatch:
        got:  f87a5cf877f875a056d2ec37506794f501e349a0a04f91e9256d9beb13b832428d6bff9d0fe0c134820775c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207758080e69471562b71999873db5b286df957af199ec94617f790cf82077589cefac791f0dfab204b8080c0
        want: f87a5df877f875a056d2ec37506794f501e349a0a04f91e9256d9beb13b832428d6bff9d0fe0c134820775c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207758080e69471562b71999873db5b286df957af199ec94617f790cf82077589cefac791f0dfab204b8080c0
    handler_test.go:166: test 93: diff layer mismatch: message payload mismatch:
        got:  f87a5df877f875a081667500e51b53b021fd2f5cf8af84db26ee8e2b61a864aa81a2204fd8064510820772c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207728080e69471562b71999873db5b286df957af199ec94617f790cf82077289cea78349baf35ad10e8080c0
        want: f87a5ef877f875a081667500e51b53b021fd2f5cf8af84db26ee8e2b61a864aa81a2204fd8064510820772c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207728080e69471562b71999873db5b286df957af199ec94617f790cf82077289cea78349baf35ad10e8080c0
    handler_test.go:166: test 94: diff layer mismatch: message payload mismatch:
        got:  f87a5ef877f875a02b8eee8bb11229232833892d886511a60b4eb5eb7c305ab88971120d0ff7d215820761c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207618080e69471562b71999873db5b286df957af199ec94617f790cf82076189cccfab05deb83e655f8080c0
        want: f87a5ff877f875a02b8eee8bb11229232833892d886511a60b4eb5eb7c305ab88971120d0ff7d215820761c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808207618080e69471562b71999873db5b286df957af199ec94617f790cf82076189cccfab05deb83e655f8080c0
    handler_test.go:166: test 95: diff layer mismatch: message payload mismatch:
        got:  f87a5ff877f875a00333163e3ae00b71364205d8a12c25241fab63e5b3a28ec4a7ae131c9fa2d39b8204d0c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204d08080e69471562b71999873db5b286df957af199ec94617f790cf8204d0898594413fbd8f8a9c308080c0
        want: f87a60f877f875a00333163e3ae00b71364205d8a12c25241fab63e5b3a28ec4a7ae131c9fa2d39b8204d0c6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808204d08080e69471562b71999873db5b286df957af199ec94617f790cf8204d0898594413fbd8f8a9c308080c0
    handler_test.go:166: test 96: diff layer mismatch: message payload mismatch:
        got:  f87a60f877f875a00194b8c90cdf49a1b0703b462d62f454911f0dc28f2a5d8d20a8ec1bd28133de8206acc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206ac8080e69471562b71999873db5b286df957af199ec94617f790cf8206ac89b92fe8abd406a663548080c0
        want: f87a61f877f875a00194b8c90cdf49a1b0703b462d62f454911f0dc28f2a5d8d20a8ec1bd28133de8206acc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c6808206ac8080e69471562b71999873db5b286df957af199ec94617f790cf8206ac89b92fe8abd406a663548080c0
    handler_test.go:166: test 97: diff layer mismatch: message payload mismatch:
        got:  f87a61f877f875a0464eb8c587308c38493756ee95783ea569cbc0a60e94850db18872f73bced8a182045bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082045b8080e69471562b71999873db5b286df957af199ec94617f790cf82045b8978e4da3f868f4e89e58080c0
        want: f87a62f877f875a0464eb8c587308c38493756ee95783ea569cbc0a60e94850db18872f73bced8a182045bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082045b8080e69471562b71999873db5b286df957af199ec94617f790cf82045b8978e4da3f868f4e89e58080c0
    handler_test.go:166: test 98: diff layer mismatch: message payload mismatch:
        got:  f87a62f877f875a03f5080502bd7b9031260edb0b03295e81f8f339b7c5e331155fec985855afc6182042bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082042b8080e69471562b71999873db5b286df957af199ec94617f790cf82042b8973b095bc27ca4996158080c0
        want: f87a63f877f875a03f5080502bd7b9031260edb0b03295e81f8f339b7c5e331155fec985855afc6182042bc6c501825208c0c0c0f845dd94010000000000000000000000000000000000000087c68082042b8080e69471562b71999873db5b286df957af199ec94617f790cf82042b8973b095bc27ca4996158080c0
    handler_test.go:173: test 71: diff layer mismatch: message payload mismatch:
        got:  c247c0
        want: c248c0
    handler_test.go:173: test 72: diff layer mismatch: message payload mismatch:
        got:  c248c0
        want: c249c0
    handler_test.go:173: test 73: diff layer mismatch: message payload mismatch:
        got:  c249c0
        want: c24ac0
    handler_test.go:173: test 74: diff layer mismatch: message payload mismatch:
        got:  c24ac0
        want: c24bc0
    handler_test.go:173: test 75: diff layer mismatch: message payload mismatch:
        got:  c24bc0
        want: c24cc0
    handler_test.go:173: test 76: diff layer mismatch: message payload mismatch:
        got:  c24cc0
        want: c24dc0
    handler_test.go:173: test 77: diff layer mismatch: message payload mismatch:
        got:  c24dc0
        want: c24ec0
    handler_test.go:173: test 78: diff layer mismatch: message payload mismatch:
        got:  c24ec0
        want: c24fc0
    handler_test.go:173: test 79: diff layer mismatch: message payload mismatch:
        got:  c24fc0
        want: c250c0
    handler_test.go:173: test 80: diff layer mismatch: message payload mismatch:
        got:  c250c0
        want: c251c0
    handler_test.go:173: test 81: diff layer mismatch: message payload mismatch:
        got:  c251c0
        want: c252c0
    handler_test.go:173: test 82: diff layer mismatch: message payload mismatch:
        got:  c252c0
        want: c253c0
    handler_test.go:173: test 83: diff layer mismatch: message payload mismatch:
        got:  c253c0
        want: c254c0
    handler_test.go:173: test 84: diff layer mismatch: message payload mismatch:
        got:  c254c0
        want: c255c0
    handler_test.go:173: test 85: diff layer mismatch: message payload mismatch:
        got:  c255c0
        want: c256c0
    handler_test.go:173: test 86: diff layer mismatch: message payload mismatch:
        got:  c256c0
        want: c257c0
    handler_test.go:173: test 87: diff layer mismatch: message payload mismatch:
        got:  c257c0
        want: c258c0
    handler_test.go:173: test 88: diff layer mismatch: message payload mismatch:
        got:  c258c0
        want: c259c0
    handler_test.go:173: test 89: diff layer mismatch: message payload mismatch:
        got:  c259c0
        want: c25ac0
    handler_test.go:173: test 90: diff layer mismatch: message payload mismatch:
        got:  c25ac0
        want: c25bc0
    handler_test.go:173: test 91: diff layer mismatch: message payload mismatch:
        got:  c25bc0
        want: c25cc0
    handler_test.go:173: test 92: diff layer mismatch: message payload mismatch:
        got:  c25cc0
        want: c25dc0
    handler_test.go:173: test 93: diff layer mismatch: message payload mismatch:
        got:  c25dc0
        want: c25ec0
    handler_test.go:173: test 94: diff layer mismatch: message payload mismatch:
        got:  c25ec0
        want: c25fc0
    handler_test.go:173: test 95: diff layer mismatch: message payload mismatch:
        got:  c25fc0
        want: c260c0
    handler_test.go:173: test 96: diff layer mismatch: message payload mismatch:
        got:  c260c0
        want: c261c0
    handler_test.go:173: test 97: diff layer mismatch: message payload mismatch:
        got:  c261c0
        want: c262c0
    handler_test.go:173: test 98: diff layer mismatch: message payload mismatch:
        got:  c262c0
        want: c263c0
FAIL
FAIL	github.com/ethereum/go-ethereum/eth/protocols/diff	3.104s

### Description Merge upstream fix [1379](bnb-chain#1379). The tests panic quite frequently. ### Rationale The tests no longer panic. I manager to trigger the error (almost) every time with this command: ``` seq 1 10 | parallel go test -count=1 ./eth/downloader -run "TestCanonicalSynchronisation66Full" -v ``` --------- Co-authored-by: 0xcb9ff9 <[email protected]> Co-authored-by: Larry <[email protected]>

commit bb6bdc055d1a7f1f049c924028ad8aaf04291b3b Merge: 7a19cd27b 1c17c47df Author: lx <[email protected]> Date: Mon Sep 11 17:43:19 2023 +0800 Merge pull request #1860 from bnb-chain/develop draft release v1.2.12 commit 1c17c47df7d73f2d38017f2e89082190b1136d5d Author: lx <[email protected]> Date: Fri Sep 8 14:20:19 2023 +0800 release: prepare for release v1.2.12 (#1859) commit 5a7964ded25835b8e5ad69fc070e35da13e8bc6e Author: Mister-EA <[email protected]> Date: Fri Sep 8 04:36:53 2023 +0200 Update init-network command (#1839) * cmd: remove genesis from config.toml * cmd: add check for port number commit 6af61622970a2b7206c8f80433048bf6d243cc07 Author: NathanBSC <[email protected]> Date: Fri Sep 8 10:20:07 2023 +0800 vote: check consensus key match vote key before voting (#1858) commit a0cb4d0377b36c143dc7f974387f416d51de3597 Author: Eric <[email protected]> Date: Thu Sep 7 16:46:54 2023 +0800 eth/tracers: trace system tx should add intrinsicGas (#1855) commit a4373557dfdc0315cebb10d9720fe025106c4054 Author: lx <[email protected]> Date: Wed Sep 6 21:53:47 2023 +0800 fetcher: no import blocks before or equal to the finalized height (#1854) commit 3f0158751e8a779e496dc299fe18b423b603f5bb Merge: df8db4f22 d40f382fe Author: Matus Kysel <[email protected]> Date: Wed Sep 6 15:40:03 2023 +0200 Merge pull request #1852 from bnb-chain/bootnodes discov: add hardcoded bootnodes commit d40f382fe12ee950bac8ca3aa8aad8e5dc654731 Author: Matus Kysel <[email protected]> Date: Tue Sep 5 08:44:05 2023 +0200 doc: add simple guide to run bootnode commit 50f1cf3aa92223587341821796a0e70558ce80d6 Author: Matus Kysel <[email protected]> Date: Tue Sep 5 08:23:51 2023 +0200 discov: add hardcoded bootnodes commit df8db4f22cbf8f4749d32dacd7ea1dc8ed80fb6b Author: buddho <[email protected]> Date: Tue Aug 29 18:09:24 2023 +0800 crypto: Update BLST to v0.3.11 (#1844) commit 7a19cd27b61b342d24a1584efc7fa00de4a5b4f5 Merge: c431373bd c035b0c81 Author: lx <[email protected]> Date: Wed Aug 23 11:32:08 2023 +0800 Merge pull request #1833 from bnb-chain/develop draft release v1.2.11 commit c431373bd55cfd47fa5061f540ea767cdab2574c Author: lx <[email protected]> Date: Tue Aug 22 21:35:43 2023 +0800 ci: increase header-max-length from 72 to 80 for master branch (#1834) PR merge will append the PR number at the end, like:... (#1805), which has extra 8 characters commit c035b0c8166b89c18911a998dcebbc51614b6e33 Author: lx <[email protected]> Date: Tue Aug 22 11:10:53 2023 +0800 release: prepare for release v1.2.11 (#1832) commit e2bf0f3fbd2ba71b42130daf26b42c4243806d0d Author: lx <[email protected]> Date: Mon Aug 21 10:31:18 2023 +0800 fix: lagging nodes failed to sync (#1829) FastFinality puts more infor into the header.extra field to keep vote information. For mainnet, on epoch height, it could be 1526 bytes, which was 517 bytes before. So the hardcoded 700 bytes for header could be no longer enough, increase it by 2 times would be enough. this bug could cause P2P sync failure for nodes that are lagging behind, since they would request access of ancient db, and GetBlockHeaders could be failed. commit 0bc5a2a2d7f146ecb13181ea5d12e61234fc4c06 Author: NathanBSC <[email protected]> Date: Tue Aug 15 11:40:52 2023 +0800 client: add FinalizedHeader/Block to use the fast finality (#1797) commit 9b95339c383221a444f36b668d21691197aff6fd Author: NathanBSC <[email protected]> Date: Mon Aug 14 17:48:36 2023 +0800 vote: remove DisableBscProtocol and add flag to skip votes assmebling (#1805) commit 2b836937a2bbb1fe881bbacfafba6217226e05ee Merge: 34b065aec c208d28a6 Author: lx <[email protected]> Date: Thu Aug 3 11:58:13 2023 +0800 Merge pull request #1793 from bnb-chain/develop draft release v1.2.10 commit c208d28a68c414541cfaf2651b7cff725d2d3221 Author: NathanBSC <[email protected]> Date: Thu Aug 3 10:05:54 2023 +0800 tool: add a tool extradump to parse extra data after luban (#1795) commit 0fb32163b07813bfb05c8319eac8e32a120e40f3 Author: lx <[email protected]> Date: Wed Aug 2 20:09:45 2023 +0800 release: prepare for release v1.2.10 (#1792) commit 54dbb2ba057928e4c6e02913a58e4fd3b0d7d5c3 Author: NathanBSC <[email protected]> Date: Wed Aug 2 18:10:04 2023 +0800 finality: add more check to ensure reuslt of assembleVoteAttestation (#1791) commit 522d4cd88039c2f174e13dfc8c8099e08f00431c Author: NathanBSC <[email protected]> Date: Wed Aug 2 14:50:32 2023 +0800 vote: backup validator sync votes from corresponding mining validator (#1778) commit 4525cff920f60edae5048f9aeb7d017f9ea7a2bf Author: NathanBSC <[email protected]> Date: Wed Aug 2 14:47:35 2023 +0800 fix: exclude same votes when doing malicious voting check (#1784) commit 909e7b9314799bfb9b81bc66295ebbe5b427aa5a Author: Eric <[email protected]> Date: Wed Aug 2 14:06:24 2023 +0800 metrics: add txpool config into metrics server (#1788) commit 54b4e5838297d413d75b97b1bdaf6f0e45068d9b Author: NathanBSC <[email protected]> Date: Wed Aug 2 14:05:46 2023 +0800 rpc: add GetFinalizedHeader/Block to simplify using the fast finality (#1789) commit f616c36ebf7e68e6dd6a16249e5209696e82414f Author: NathanBSC <[email protected]> Date: Mon Jul 31 10:44:02 2023 +0800 log: reduce logs when receiving too much votes from a peer (#1780) commit 278608a04eab66ab9e7947b22b53fb2a0622835a Author: Matus Kysel <[email protected]> Date: Thu Jul 27 15:39:04 2023 +0200 discov: do not filter out bootnodes (#1773) commit 34b065aecb80aa7733e1e6fe77b9b080dff1699a Merge: 5f87ddf9f 83cc950b6 Author: lx <[email protected]> Date: Fri Jul 21 17:35:10 2023 +0800 Merge pull request #1777 from bnb-chain/develop release: draft release v1.2.9 commit 83cc950b6b641540ee002c48d78f9b07b300074d Author: larry.lx <[email protected]> Date: Fri Jul 21 11:50:37 2023 +0800 release: prepare for release v1.2.9 commit 9219c883e30c305315989271b59c6eeebde780a2 Author: larry.lx <[email protected]> Date: Fri Jul 21 11:36:25 2023 +0800 upgrade: mainnet hardfork block height for: Plato, Hertz Hertz is equal to Berlin and London - Plato will be enabled on BSC mainnet at height: 30720096 - Hertz will be enabled on BSC mainnet at height: 31302048 Hertz is for ecosystem compatibility, to enable some customized EIPs of Berlin&London on BSC commit 5742cc286ce93a2086edcb3ae9f176d6cc035a89 Author: Matus Kysel <[email protected]> Date: Wed Jul 12 02:48:13 2023 +0200 discov: increase bucket size for bootnodes (#1727) commit 3fd5b0c149aabe79a589117cb5b7b1049e99dfeb Author: NathanBSC <[email protected]> Date: Tue Jul 11 10:13:08 2023 +0800 fix: defend ddos voting attack with other mini fix according to audit (#1741) commit 288804ced044ebffbab6d1c7537792234979e6e1 Merge: d565b9cb1 78d6ae741 Author: Matus Kysel <[email protected]> Date: Mon Jul 10 09:45:10 2023 +0200 Merge pull request #1739 from bnb-chain/tracing-timeout eth/tracers: add multiplexing tracer commit d565b9cb122cb4038ab34af4d6acebcc8e1d307a Merge: 5ba63e307 7487f79eb Author: alexlucaci <[email protected]> Date: Fri Jun 30 18:18:39 2023 +0300 Merge pull request #1725 from bnb-chain/uncomment-log-trace Uncomment log trace commit 5ba63e3071b55a462eb687bc7fc8aacfdec911b9 Author: alexlucaci <[email protected]> Date: Fri Jun 30 18:09:26 2023 +0300 log: added option to rotate logs based on number of hours with a maximum of 24 (#1735) log: added daily rotate option which overrides hourly commit 5f87ddf9f6e028653c70ff2b02145593277a35de Author: lx <[email protected]> Date: Fri Jun 30 12:06:56 2023 +0800 docs: some url update (#1742) commit 8a430c06a9655ac13b145aa3b7bb6399f0110694 Author: lx <[email protected]> Date: Fri Jun 30 12:06:56 2023 +0800 docs: some url update (#1742) commit 78d6ae7415a323069d58b7ad2dfc71c2e701b413 Author: Sina Mahmoodi <[email protected]> Date: Tue Nov 8 12:46:52 2022 +0330 eth/tracers: add multiplexing tracer (#26086) * eth/tracers: add native multiplexing tracer * minor improv callTracer * mv evm cancellation to api commit fd58e6f0ac40d443bf4b4aed68740c4fc0501a34 Merge: 9ed95d826 dda8e8da6 Author: lx <[email protected]> Date: Tue Jun 27 14:08:04 2023 +0800 Merge pull request #1737 from bnb-chain/develop release: draft release v1.2.8 commit dda8e8da6a8662ef42688945fe32bb91054ba95b Author: lx <[email protected]> Date: Tue Jun 27 13:01:58 2023 +0800 release: prepare for release v1.2.8 (#1736) commit 291cb8ab51bf93d9bcbf6b89bff7b604e85a4516 Author: lmittmann <[email protected]> Date: Tue Jun 27 05:52:31 2023 +0200 eth/filters, ethclient/gethclient: add fullTx option to pending tx filter (#25186) (#1626) This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes. In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly. Co-authored-by: lx <[email protected]> Co-authored-by: lmittmann <[email protected]> Co-authored-by: Felix Lange <[email protected]> commit 598c36bcea53b0b9bf05ba64143488dbddc682a7 Author: NathanBSC <[email protected]> Date: Tue Jun 27 08:59:08 2023 +0800 fix: avoid to block the chain when failed to send votes (#1734) commit 69fd672ded5e6e9565b9fcff6e1b498de7781993 Author: NathanBSC <[email protected]> Date: Sun Jun 25 14:11:17 2023 +0800 feat: support password flag when handling bls keys (#1726) commit 7487f79eb00e68520cd086aaa8a59beef548970d Author: Alex Lucaci <[email protected]> Date: Tue Jun 20 16:06:56 2023 +0300 fix: typo commit 9ed95d826e626455c54461aac860a038d5539245 Merge: cf64a044a be7ee9217 Author: lx <[email protected]> Date: Tue Jun 20 20:01:00 2023 +0800 Merge pull request #1723 from bnb-chain/develop release: draft release v1.2.7 commit be7ee9217ff3ebf779893d16fa0f93f2576ac9a8 Author: lx <[email protected]> Date: Tue Jun 20 18:54:25 2023 +0800 release: prepare for release v1.2.7 (#1724) commit dde94542c18ff3e70875f8b6095b7a12d2291c46 Author: Alex Lucaci <[email protected]> Date: Tue Jun 20 13:20:26 2023 +0300 fix: uncommented log.Trace while also tracking the sender again commit a27ece8d0a99afb40f0cd0a11c76029de730f6fd Author: KeefeL <[email protected]> Date: Tue Jun 20 18:04:18 2023 +0800 lightclient: fix validator set change (#1645) commit dc454a1ca7c5240fe43cce3f21043cf3ed26a456 Author: NathanBSC <[email protected]> Date: Tue Jun 20 13:40:23 2023 +0800 feat: support creating a bls keystore from a specified private key (#1717) commit f45526395048e6cf646d3aee95576f45070d8527 Author: NathanBSC <[email protected]> Date: Tue Jun 20 10:58:13 2023 +0800 metrics: add counter for voting status of whole network (#1720) commit cf64a044afdb72d336811996794acca7f6830639 Merge: 53fef9e83 acd2f5f24 Author: lx <[email protected]> Date: Fri Jun 16 17:12:04 2023 +0800 Merge pull request #1696 from bnb-chain/develop release: draft release v1.2.6 commit acd2f5f249ba578aec86a8cd7d95338adb792377 Author: dylanhuang <[email protected]> Date: Fri Jun 16 13:32:58 2023 +0800 p2p: fix length calculation for headPeers method (#1708) commit 9841ba5bdc0696dae1b2eb72c651dd2642f08927 Merge: 55bb1086c 53fef9e83 Author: lx <[email protected]> Date: Fri Jun 16 06:29:14 2023 +0800 Merge branch 'master' into develop commit 55bb1086ca9abfa7913025d174b8406353004ad5 Author: larry.lx <[email protected]> Date: Wed Jun 14 17:48:55 2023 +0800 release: prepare for release v1.2.6 commit 019aedc17e309e44d8af06c784ef729c30fbc476 Author: larry.lx <[email protected]> Date: Thu Jun 15 17:41:37 2023 +0800 upgrade: block height of Hertz(London&Berlin) on testnet commit 1ace44b9cadf2f6a8ee0161d87322da85723750d Author: larry.lx <[email protected]> Date: Thu Jun 8 13:57:31 2023 +0800 release: prepare for release v1.2.5 commit cd44fc40ffc36c83f48525fe05a4403e1f241b89 Merge: 486e01988 73397217e Author: Mister-EA <[email protected]> Date: Thu Jun 15 17:26:35 2023 +0200 Merge pull request #1704 from bnb-chain/default-config-reflection core: use reflection to set default block values commit 486e01988098ef85dfe4ce02b5dbb45cb11206b0 Author: NathanBSC <[email protected]> Date: Thu Jun 15 17:09:27 2023 +0800 core/statedb: always clear out access list when setting a new one (#1702) Co-authored-by: Péter Szilágyi <[email protected]> commit 73397217e2624d3f4ed53bb15797a3c6eb1574ef Author: Mister-EA <[email protected]> Date: Thu Jun 15 10:31:42 2023 +0200 core: use reflection to set default block values commit e31270aa389701f33eccf46fe1cbd6bcc351f813 Merge: 23ba7b089 4560dc2f6 Author: Matus Kysel <[email protected]> Date: Wed Jun 14 10:42:10 2023 +0200 Merge pull request #1694 from bnb-chain/improve-readme readme: add minimal compiler version commit 23ba7b08930712149d27c6973a97261f231948a0 Merge: 3dca64030 2cd0387cb Author: Mister-EA <[email protected]> Date: Wed Jun 14 10:10:59 2023 +0200 Merge pull request #1695 from sunny2022da/2718-test-dev test: Add EIP-2718 unit test for parlia ChainConfig commit 2cd0387cbe49bdcbebc7ee2741911326ef912f80 Author: Sunny <[email protected]> Date: Tue Jun 13 18:35:32 2023 +0800 test: Add EIP-2718 unit test for parlia ChainConfig commit 4560dc2f667a3ec342c135d7882d8cc846f0fbfa Author: Matus Kysel <[email protected]> Date: Tue Jun 13 10:25:07 2023 +0200 readme: add minimal compiler version commit 3dca640303f31ec26d38e013443d658e1ef06357 Author: lx <[email protected]> Date: Tue Jun 13 14:14:45 2023 +0800 config: use default fork config if not specified in config.toml (#1654) commit 15c30b73f85de187378b253f60b0597b02a43d2e Merge: 38002f8a5 4a467ecc5 Author: Mister-EA <[email protected]> Date: Mon Jun 12 14:11:24 2023 +0200 Merge pull request #1676 from bnb-chain/eip3529-tests-parlia EIP-3529 (BEP-212) Unit tests for Parlia Config commit 4a467ecc5f7f9ee527d904fd22c1c3161c4e2b67 Merge: a97f71328 b1fbb294e Author: Mister-EA <[email protected]> Date: Mon Jun 12 11:54:13 2023 +0200 Merge pull request #1686 from bnb-chain/refactor-eip3529-tests eip3529tests: refactor tests commit 38002f8a569e5dc9ce70a7eaba809857113713dd Author: NathanBSC <[email protected]> Date: Mon Jun 12 13:31:18 2023 +0800 fix: set the signer of parlia to the most permissive one (#1682) commit b1fbb294ea0f3288704defc08aec88cd9ce8d0a7 Author: Mister-EA <[email protected]> Date: Fri Jun 9 12:27:31 2023 +0200 eip3529tests: refactor tests commit ff32314de03db2ddab54d42fa161b68c8ab0b9cd Author: NathanBSC <[email protected]> Date: Thu Jun 8 17:32:07 2023 +0800 fix: not double GasLimit of block upon London upgrade (#1681) commit 53fef9e830fe55037e63ffe8abc1b564b9401784 Merge: 3c5f54fc8 dd5b69b86 Author: lx <[email protected]> Date: Thu Jun 8 17:18:22 2023 +0800 Merge pull request #1678 from brilliant-lx/leveldb_downgrade_master release: draft release v1.2.5 commit 78ad0496419338d4c77bac04f76feda04e247a81 Author: yutianwu <[email protected]> Date: Thu Jun 8 14:40:10 2023 +0800 fix: check integer overflow when decode crosschain payload (#1679) commit cf9efe5761fb3f6371553cfad1b9d0fd34559dbe Author: NathanBSC <[email protected]> Date: Thu Jun 8 14:37:24 2023 +0800 fix: voting can only be enabled when mining (#1671) commit dd5b69b8632fe377d3119f2e616c153829798b50 Author: larry.lx <[email protected]> Date: Thu Jun 8 13:57:31 2023 +0800 release: prepare for release v1.2.5 commit bc543bae6705e66e9ec564524a333215cc3db59b Author: lx <[email protected]> Date: Thu Jun 8 11:58:15 2023 +0800 goleveldb: downgrade the version for performance (#1675) this PR: https://github.com/bnb-chain/bsc/pull/936 upgraded the goleveldb indirectly, since it has dependency of prysm, which also depends on goleveldb indrectly. But the new version has some performance issue on Databse Close, see: https://github.com/syndtr/goleveldb/issues/434 So we need to rollback to the previous verison commit d6feb729c565aabba70c677f744c2f5155411ad0 Author: lx <[email protected]> Date: Thu Jun 8 11:58:15 2023 +0800 goleveldb: downgrade the version for performance (#1675) this PR: https://github.com/bnb-chain/bsc/pull/936 upgraded the goleveldb indirectly, since it has dependency of prysm, which also depends on goleveldb indrectly. But the new version has some performance issue on Databse Close, see: https://github.com/syndtr/goleveldb/issues/434 So we need to rollback to the previous verison commit a97f71328622eb3084f996c1ffc18d0a3758c962 Author: Mister-EA <[email protected]> Date: Wed Jun 7 16:11:30 2023 +0200 parlia_tests: update comment commit 4afd224350d6dd51a1a6137da0aafbff42241577 Author: Mister-EA <[email protected]> Date: Wed Jun 7 14:16:01 2023 +0200 core: add eip3529 tests for parlia config commit f316b1d08687a41048d6e501b4718546930d15ed Author: Mister-EA <[email protected]> Date: Wed Jun 7 14:10:00 2023 +0200 params: introduce ParliaTestChainConfig commit e802c737abf2f68617f062b3c535de22fe3de85a Author: Ng Wei Han <[email protected]> Date: Wed May 31 22:01:28 2023 +0800 consensus, core/rawdb, miner: downgrade logs (#1662) commit b8dbf59155c5e75665dc722a4186d65f26cf5f3b Author: NathanBSC <[email protected]> Date: Wed May 31 19:35:10 2023 +0800 fix: ungraceful shutdown caused by malicious Vote Monitor (#1663) commit 86446edf55b0769daa0f7fdf5864a83785c6a78a Author: NathanBSC <[email protected]> Date: Wed May 31 14:36:31 2023 +0800 feat: add a tool for submitting evidence of malicious voting (#1660) * feat: add a tool for submitting evidence of malicious voting commit 3d8753cae66e7e626ff787e184547e9f6b9a4a59 Author: NathanBSC <[email protected]> Date: Thu May 25 14:18:01 2023 +0800 fix: remove naturally finality commit 1036dc70be1efbf3e31b2cabb20bc43013c5214b Author: Mister-EA <[email protected]> Date: Thu May 25 11:34:04 2023 +0200 core: port several London EIPs on BSC(#1422) Here is the list: a.BEP-227: Implement EIP-3198: BASEFEE opcode b.BEP-226: Implement EIP-1559 with base fee of 0 c.BEP-228: Implement EIP-3541: Prevent deploying contracts starting with 0xEF d.BEP-212: Implement EIP-3529: Reduction in Refunds commit eaea77a21c5a4f72290583817a218125f89189a8 Author: lx <[email protected]> Date: Thu May 25 08:57:02 2023 +0800 P2P: try to limit the connection number per IP address (#1623) ** by default, MaxPeersPerIp is same as MaxPeers ** no restriction on TrustedNode ** add test case: TestOptionMaxPeersPerIp commit 11d16dff3c68deaa4673c9a572b226e8054617b7 Author: lx <[email protected]> Date: Tue May 23 22:35:04 2023 +0800 readme: update the disk requirement to 2.5TB (#1642) commit 8d763bc3613703a04987cd1c746d84db397c42dd Author: NathanBSC <[email protected]> Date: Tue May 23 20:18:42 2023 +0800 fix: support getFilterChanges after NewFinalizedHeaderFilter (#1641) commit 3c5f54fc805994b0b60b50dbd59e4424df25f17a Author: lx <[email protected]> Date: Mon May 22 21:29:24 2023 +0800 release: prepare for release v1.2.4 (#1637) commit 826f613c0d68fe3eeb1734c974eb12b6655552fd Author: lx <[email protected]> Date: Mon May 22 18:53:09 2023 +0800 upgrade: block height of Luban on mainnet (#1636) commit 7b7d8c17fa58e1741142c33bfde5e9b9e756661d Author: lx <[email protected]> Date: Mon May 22 21:29:24 2023 +0800 release: prepare for release v1.2.4 (#1637) commit bd8795d649c3a315e067814c398b1116aac2add5 Author: lx <[email protected]> Date: Mon May 22 18:53:09 2023 +0800 upgrade: block height of Luban on mainnet (#1636) commit 1759c69f867af0178d64c40553d5a3e9d6a2ab4d Author: NathanBSC <[email protected]> Date: Mon May 22 11:32:34 2023 +0800 fix: getBlockByNumber support 'safe','finalized' when interact by ipc (#1628) commit 08eab8b928e6a75ae16ac928beb652286c04813c Author: sunny2022da <[email protected]> Date: Fri May 19 21:32:10 2023 +0800 feature: Enable Berlin EIPs (#1608) Enable following Berlin EIPs on BSC and introduce HertzBlock ** EIP-2565: ModExp Gas Cost ** EIP-2929: Gas cost increases for state access opcodes ** EIP-2718: Typed Transaction Envelope ** EIP-2930: Optional access lists commit bac626c39cc9af214e9344f8df85d46cc5f5bc88 Author: NathanBSC <[email protected]> Date: Fri May 19 10:56:20 2023 +0800 upgrade: avoid to modify RialtoGenesisHash when testing in rialtoNet (#1621) commit 060aba581320d59690bbe524ff25365bd4f36969 Author: larry.lx <[email protected]> Date: Thu May 18 10:30:16 2023 +0800 readme: update full sync from genesis commit 33e6f840d25edb95385d23d284846955327b0fcd Author: NathanBSC <[email protected]> Date: Thu May 11 16:29:37 2023 +0800 fix: log info when failed to verifyVoteAttestation commit 1b8ec07b2ef1755fdce581261911cebf2dc7177c Author: NathanBSC <[email protected]> Date: Thu May 11 16:29:37 2023 +0800 fix: log info when failed to verifyVoteAttestation commit e31260956dc49a72ef734f62982159585c909048 Merge: e22989f0d b0ad7428c Author: lx <[email protected]> Date: Thu May 11 16:13:16 2023 +0800 Merge pull request #1601 from bnb-chain/develop release: add another two patches into v1.2.3 commit b0ad7428c2e2e64b0a3dc3337435f664669bf22f Author: NathanBSC <[email protected]> Date: Thu May 11 14:45:15 2023 +0800 feature: add malicious vote monitor (#1597) commit 4cc78fd175b9285627713d20e6043d0aee532e56 Author: NathanBSC <[email protected]> Date: Wed May 10 11:00:54 2023 +0800 upgrade: update PlatoUpgrade contracts code (#1600) commit e22989f0db364124d241246a63ec4cc8fb023fba Merge: 542bb5b32 b90b1f592 Author: lx <[email protected]> Date: Tue May 9 12:13:49 2023 +0800 Merge pull request #1596 from bnb-chain/develop release: draft release v1.2.2 commit b90b1f592b7527f5d7af14a49c689e1e659b585c Author: lx <[email protected]> Date: Mon May 8 21:39:53 2023 +0800 release: prepare for release v1.2.2 (#1595) commit 4e2168566b851b6116234ed35938a9d1fb2ed3c4 Author: minh-bq <[email protected]> Date: Mon May 8 20:15:14 2023 +0700 fix: recently signed check when slashing unavailable validator (#1547) The first validator in snap.Recents is shifted out and allowed to seal the block already. However, when determining if we should slash the validator in Finalize and FinalizeAndAssemble, we mark that first validator as unable to seal block and don't slash this validator. This commit fixes that bug and creates a separate helper function to check if the validator recently signed a block for consistency in all places the check happens. commit 1fed0df8c2d16077d7ee0e92aae607723f67d4a3 Author: lx <[email protected]> Date: Mon May 8 17:45:17 2023 +0800 upgrade: block height of Plato on testnet (#1594) commit 7e1590c928d792c567453fea9316f0d48f032c34 Author: Roshan <[email protected]> Date: Mon May 8 17:27:40 2023 +0800 upgrade: update PlatoUpgrade contracts code (#1592) commit 031fce3c92f5834118f6469b5f6da187fda27f58 Author: Matus Kysel <[email protected]> Date: Mon May 8 09:54:12 2023 +0200 p2p/discover: implement ENR node filtering (#1320) commit acaafde15697ec222f8c7c3b6f015b406fdbc167 Author: GalaIO <[email protected]> Date: Mon May 8 13:59:26 2023 +0800 fix: fix snap flaky tests (#1590) commit 5f690d32eb7b40c0cc54691065beca8ee23a15c8 Author: NathanBSC <[email protected]> Date: Sat May 6 20:47:31 2023 +0800 metrics: add a counter for validator to check work status of voting (#1583) commit 880535c7302fee3d1489e83bd41423c866c5ef76 Author: lmittmann <[email protected]> Date: Sat May 6 05:16:27 2023 +0200 eth/tracers, core/vm: remove `time` from trace output and tracing interface (#1488) This removes the 'time' field from logs, as well as from the tracer interface. This change makes the trace output deterministic. If a tracer needs the time they can measure it themselves. No need for evm to do this. Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]> commit f8e000309cdf576e7193b2bb170b866e2661a7fd Author: Evgeny Kolyakov <[email protected]> Date: Sat May 6 05:43:44 2023 +0300 code: x = append(y) is equivalent to x = y (#866) commit daae7718a80f72537ad1a4a5d7c42f12ac5b20e5 Author: NathanBSC <[email protected]> Date: Sat May 6 09:56:10 2023 +0800 fix: support golang 1.20 by upgrading prysm to v4 (#1576) commit e794b20fa141dee20eacbeb6890f0670400650ec Author: NathanBSC <[email protected]> Date: Sat May 6 09:48:54 2023 +0800 fix: output an error log when bsc extension fail to handshake (#1578) commit 0359e063b019f61c1416bcb7e8a2ac4418948744 Author: Roshan <[email protected]> Date: Fri May 5 19:03:57 2023 +0800 upgrade: update PlatoUpgrade contracts code (#1574) commit b801f291df9e11e12c350d8b366a513ae1f2c36c Author: yutianwu <[email protected]> Date: Fri May 5 17:06:10 2023 +0800 feat: remove supports for legacy proof type (#1573) commit 9a202e027962d5efecc0c1b0d7eddfff368253e4 Author: NathanBSC <[email protected]> Date: Fri May 5 16:48:43 2023 +0800 fix: make BLST PORTABLE for release binary (#1575) commit 5b75f597b4eab6a2e9efce2dd282386556e64277 Author: NathanBSC <[email protected]> Date: Fri May 5 14:15:43 2023 +0800 fix: remove dynamic metric labels about fast finality (#1572) commit a7bdb363caccc4585b1f765a9aac81cde7b59b2d Author: NathanBSC <[email protected]> Date: Thu May 4 17:25:31 2023 +0800 fix: config for VoteJournalDir and BLSWalletDir (#1566) commit 542bb5b32e7250d98226702b8c1dbac14cb01cdc Author: lx <[email protected]> Date: Tue Apr 25 23:19:44 2023 +0800 log: revert a log back to trace level (#1528) warning level will make the log spam over the screen. commit bc72d5e7088e801cdd612837e519f9939500883e Author: lx <[email protected]> Date: Tue Apr 25 21:31:33 2023 +0800 log: revert a log back to trace level (#1527) warning level will make the log spam over the screen. commit 30c298ffa5728a71bc59522611addbefe1eaf6fd Merge: 0146b070c 779f4a80e Author: lx <[email protected]> Date: Tue Apr 25 16:43:05 2023 +0800 Merge pull request #1518 from bnb-chain/develop release: merge several PRs to master for release v1.2.0 commit 779f4a80eef3072cccb00d49edaaf8188118e68a Author: dylanhuang <[email protected]> Date: Tue Apr 25 09:11:29 2023 +0800 fix: lint error and docs (#1520) * ci: upgrade golangci-lint * build: move blst env to build stage * chore: fix lint error * docs: update readme commit 282ef8952d0196c6e4176db51e8be4e875e267e8 Author: dylanhuang <[email protected]> Date: Mon Apr 24 22:30:27 2023 +0800 ci: fix release job (#1519) * ci: remove CGO_ENABLE=0 due to blst package * ci: fix arm binary build * ci: remove arm5-7 version * ci: fix arm64 build script * ci: fix generate_change_log.sh commit b6274dd2dfd7826ea0a26c072d200b88f8755b36 Merge: 129bcfe7d 0146b070c Author: lx <[email protected]> Date: Mon Apr 24 20:13:54 2023 +0800 Merge branch 'master' into develop commit 129bcfe7de85d711471615403b122ff11566cad0 Author: NathanBSC <[email protected]> Date: Mon Apr 24 14:53:51 2023 +0800 fix: memory leak of receivedVotes (#1516) commit 265dca1a20aa47d21797b26a491e96af23f00eff Author: NathanBSC <[email protected]> Date: Mon Apr 24 14:47:17 2023 +0800 fix: simplify update of attestation (#1514) * fix: simplify update of attestation * metrics: trace verifyVoteAttestationFailed and updateAttestationFailed commit fb0893a631c6669ac76354ceb74f0c386d5876ae Author: NathanBSC <[email protected]> Date: Mon Apr 24 14:28:28 2023 +0800 fix: all votes rejected for span voting caused by reorg (#1510) * fix: all votes rejected for span voting caused by reorg * fix: change internal for recover voting to 256 from 512 commit 0146b070cba8f7c77f447d82088c61f6958a2761 Author: lx <[email protected]> Date: Fri Apr 21 18:11:32 2023 +0800 upgrade: rename hardfork to Luban & Plato (#1505) commit 0222ce7479bd1a3d929d967c549699bf2bcf3577 Author: lx <[email protected]> Date: Fri Apr 21 17:07:11 2023 +0800 upgrade: rename hardfork to Luban & Plato (#1504) commit fd6f770c66ff809fb0fa49589f04bb4e562c4241 Merge: 48aaee69e 54be51fe0 Author: lx <[email protected]> Date: Fri Apr 21 10:58:00 2023 +0800 Merge pull request #1492 from bnb-chain/develop release: draft release v1.2.0 commit 54be51fe0559b0cbd12ba042080ce4316ac1de2b Author: lx <[email protected]> Date: Fri Apr 21 10:09:55 2023 +0800 upgrade: correct the typo the commit url (#1500) commit f5c250921682e744094a1446ff6e7d579b77e29c Merge: b79df912a 48aaee69e Author: lx <[email protected]> Date: Thu Apr 20 23:06:34 2023 +0800 Merge branch 'master' into develop commit b79df912a8c346144f4c773ac5f9fc34389d5a8b Author: lx <[email protected]> Date: Thu Apr 20 23:04:45 2023 +0800 release: prepare for release v1.2.0 (#1495) commit 5f4b1258896aea935e160b42ad52a4ae61780015 Author: lx <[email protected]> Date: Thu Apr 20 22:46:54 2023 +0800 upgrade: block height of Boneh on testnet (#1490) commit 3769f25b30ee7ad9795b56fa5843950d100318ca Author: zjubfd <[email protected]> Date: Thu Apr 20 22:28:25 2023 +0800 bep: update the bytecode of boneh fork after the contract release (#1493) commit 2db1088cced0729419348e9f519a534daaee4b00 Author: Larry <[email protected]> Date: Wed Apr 19 16:19:14 2023 +0800 fix: a deadlock caused by bsc protocol handeshake timeout (#1484) commit cbbe7de6d3ea9678f8ec8190455409fb64ca3053 Author: Larry <[email protected]> Date: Wed Apr 19 15:34:33 2023 +0800 feature: remove diff protocol registration (#1486) commit bbd4e9252fa926bb5c4f44bdfb3b92054a3e093a Author: KeefeL <[email protected]> Date: Tue Apr 18 15:51:26 2023 +0800 BEP-221: implement cometBFT light block validation (#1463) commit 79e1554c211d259ae9146ae13d0db6e0c05ef265 Author: Satyajit Das <[email protected]> Date: Tue Apr 18 07:58:53 2023 +0100 genesis: add BEP174 changes to relayer contract (#1325) Co-authored-by: Matus Kysel <[email protected]> commit 6793e4b90387f6f6ae97bcc91fb84f526d8526ed Author: sunny2022da <[email protected]> Date: Tue Apr 18 14:53:09 2023 +0800 Revert "Implement 2 EIPS: limit and meter initcode and PUSH0 instructions (#1443)" (#1480) This reverts commit b4f1cdffd55b7e27facec4d250009ad440d8ac74. Revert because previous hardfork (berlin, london) need to be merged first to avoid dependencies risk commit 3b4dda4aa9298f709c9fb172b5c8237badfbb068 Merge: d6b3a9a41 39497e088 Author: Matus Kysel <[email protected]> Date: Tue Apr 18 08:09:32 2023 +0200 Merge pull request #1357 from bnb-chain/eip4338-api Integration API for EIP-4337 bundler with an L2 validator/sequencer commit d6b3a9a4171c83cb873c0dacd4dde378de4232c6 Author: NathanBSC <[email protected]> Date: Mon Apr 17 22:23:08 2023 +0800 fix: improvements after testing fast finality (#1434) commit 52ff84fb636c67cdb903957886a38eeef207e8af Author: Larry <[email protected]> Date: Mon Apr 17 11:41:05 2023 +0800 release: prepare for release v1.1.23 (#1476) commit 48aaee69e9cb50fc2cedf1398ae4b98b099697db Merge: 82e38f6fc dbe1f20ba Author: Larry <[email protected]> Date: Mon Apr 17 11:40:38 2023 +0800 Merge pull request #1474 from brilliant-lx/fix_waitgroup_master release: prepare for release v1.1.23 commit dbe1f20bad650670085c999891e31a4deb7898ee Author: larry.lx <[email protected]> Date: Sun Apr 16 18:52:17 2023 +0800 release: prepare for release v1.1.23 commit 9d4f94fa45f5077d0b0a7df75e6b239db40c3047 Author: Larry <[email protected]> Date: Sun Apr 16 15:36:52 2023 +0800 fix: panic on using WaitGroup after it is freed (#1464) commit 2b0f56898d233cefee3b17e8ad61529660f5cd92 Author: Larry <[email protected]> Date: Sun Apr 16 15:36:52 2023 +0800 fix: panic on using WaitGroup after it is freed (#1464) commit 39497e088a5b64b19ff88de609785a33c1d160d9 Author: Matus Kysel <[email protected]> Date: Fri Mar 31 08:59:45 2023 +0200 ethapi: add basic test for sendcondtionaltrx commit 994daa1447e7134db4fa552332ce5a808ec66902 Author: Matus Kysel <[email protected]> Date: Fri Mar 31 08:34:47 2023 +0200 statedb: add function to get state trie root commit f8c5f55652d4a3f8a5989c9b361e0ada6a5ddec8 Author: Matus Kysel <[email protected]> Date: Wed Mar 29 21:55:41 2023 +0200 ethapi: introduce tests for transaction options commit 26c69a15bacb5a20c554d097c4fa3da80883f476 Author: Matus Kysel <[email protected]> Date: Wed Mar 22 08:23:26 2023 +0100 internal/ethapi: cleaner designed and improved check commit c0fd04db1e2880daf810c5f84d2d7b980dba393b Author: Matus Kysel <[email protected]> Date: Tue Mar 14 21:26:20 2023 +0100 internal/ethapi: implement API for EIP-4337 commit e4b6ab9ba37fe4213d7f95274daabba0decc525b Author: Leon <[email protected]> Date: Fri Apr 14 09:52:15 2023 +0800 cmd/faucet: clear reqs list when reorg to lower nonce (#1458) commit b4f1cdffd55b7e27facec4d250009ad440d8ac74 Author: sunny2022da <[email protected]> Date: Thu Apr 13 17:26:21 2023 +0800 Implement 2 EIPS: limit and meter initcode and PUSH0 instructions (#1443) * core/vm: deepcopy jumptable when enabling extra eips When the interpreter is configured to use extra-eips, this change makes it so that all the opcodes are deep-copied, to prevent accidental modification of the 'base' jumptable. Original-auther: yihuang <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> * core/vm: implement EIP-3860: Limit and meter initcode Implementation of https://eips.ethereum.org/EIPS/eip-3860, limit and meter initcode. Most of this change takes the go-ethereum implementation as reference. Original-author: Andrei Maiboroda <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]> * core/vm: implement EIP-3855: PUSH0 instruction * core/vm: Implement PUSH0 * Move PUSH0 to enable3855 * Add method doc Original-author: Alex Beregszaszi <[email protected]> * core/vm: enable EIP-3855 (PUSH0) in Boneh Original-author: Andrew Ashikhmin <[email protected]> * core/vm: Fix issue of incorrect instructionSet used for jump_table Also update the related test case for gas change. * core/vm: fix test cases issues that not suitable for boneh * core/vm: reuse ErrMaxInitCodeSizeExceeded as error message --------- Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]> commit 82e38f6fc3c2545cf78edcf9f66b88fabb8d3aff Author: GalaIO <[email protected]> Date: Wed Apr 12 14:45:49 2023 +0800 docker: upgrade alpine version & remove apks version; (#1441) commit f7d15e34dff4660684e22df81f4733666d0ec8c9 Author: realuncle <[email protected]> Date: Mon Apr 10 18:36:45 2023 +0800 BEP-126: Introduce Fast Finality Mechanism (#936) commit 33426f2bd3bef55184bb0a695d3e8cc75e6f2668 Author: GalaIO <[email protected]> Date: Mon Apr 10 16:00:17 2023 +0800 docker: upgrade alpine version & remove apks version; (#1430) commit d0f3f8ee62cf76c8bff902db41c29ed3809931ed Merge: e4381a5d2 0cc7cb4bf Author: Larry <[email protected]> Date: Mon Apr 10 10:10:22 2023 +0800 Merge pull request #1423 from bnb-chain/develop release: draft release v1.1.22 commit 0cc7cb4bf089e7879c84f3091a6e15a560d6dfb1 Merge: 9d6e53c45 e4381a5d2 Author: larry.lx <[email protected]> Date: Sun Apr 9 14:19:17 2023 +0800 Merge remote-tracking branch 'bnb-chain/master' into HEAD commit 9d6e53c4575ecacad7a8582b317ff7b501e0279e Author: Larry <[email protected]> Date: Fri Apr 7 20:06:38 2023 +0800 release: prepare for release v1.1.22 (#1418) commit 1093ad8bf96d9aaf0ebb3fe30e7aed51ca438069 Author: NathanBSC <[email protected]> Date: Thu Apr 6 12:24:04 2023 +0800 fix: init-network with config.toml without setting TimeFormat (#1412) commit f9f5cc2157db1a034f7fdf371410a1ba346af87f Author: Leon <[email protected]> Date: Thu Apr 6 11:17:53 2023 +0800 cmd/faucet: merge ipfaucet2 branch to develop (#1361) * add ip ratelimit * update * update * update explorer adddress * updae recapcha * remove binance * cmd/faucet: fix conn to wrapped wsconn * cmd/faucet: keystore updated to save and load one same addres once * clean: remove btcd v0.20.1-beta and avoid to ambiguous import (#1) * ci: fix truffle test (#1384) --------- Co-authored-by: fudongbai <[email protected]> Co-authored-by: Nathan <[email protected]> commit 221ef7d80d161f918bb887da0b7ce777e9090bf6 Author: Nicolas Gotchac <[email protected]> Date: Mon Apr 3 16:11:09 2023 +0200 UT: fix some flaky tests (#1379) * core/state: Remove prefetcher on stop * core/blockchain: Wait for `triedb.Dereference` in `writeBlockWithState` * eth/protocols/diff: Fix index mismatch in `TestGetDiffLayers` commit bd76c258a4b14f26ce760585e391ad07b88ee431 Author: GalaIO <[email protected]> Date: Thu Mar 30 21:12:59 2023 +0800 Makefile: fix devtools install error; commit e4381a5d250b177950cdff6855c00ae14b70365c Author: dylanhuang <[email protected]> Date: Mon Apr 3 10:22:49 2023 +0800 log: support custom time format configuration (#1401) commit 3b547a985542b9b441407734b406e5aae6719400 Author: dylanhuang <[email protected]> Date: Mon Apr 3 10:22:49 2023 +0800 log: support custom time format configuration (#1401) commit af7f0dd30b80415c27e4786940476f05b033eb0b Author: Leon <[email protected]> Date: Wed Mar 29 17:36:24 2023 +0800 consnesus/parlia: abort sealing when block in the same height has upd… (#1382) commit 75529530a26cf3a3cc53909518359b8bd55e4c27 Author: Larry <[email protected]> Date: Wed Mar 29 16:51:48 2023 +0800 fix: snapshot generation issue after chain reinit from a freezer (#1381) commit ece84d4dcda5c2c242ebf29165cc19b45ec167df Author: Leon <[email protected]> Date: Tue Mar 28 15:52:40 2023 +0800 miner: no need to broadcast sidechain header mined by this validator (#1383) commit 6e06ed108797a26280969266df9b5e2a1ec7c83c Merge: fc4303c6c ce609339a Author: Larry <[email protected]> Date: Mon Mar 27 16:47:47 2023 +0800 Merge pull request #1390 from bnb-chain/develop release: draft release v1.1.21 commit ce609339ade0e418a92b0f4a36b272a055817c08 Author: Larry <[email protected]> Date: Mon Mar 27 09:48:59 2023 +0800 release: prepare for release v1.1.21 (#1395) commit e8d2c8110c111a3410b2e9b27cc7525e1f1904ce Author: Larry <[email protected]> Date: Fri Mar 24 16:55:09 2023 +0800 upgrade: update the fork height of planck upgrade on mainnet (#1389) commit ca20bc13f07690c5b9e1ab23e5bf87d12f34500b Author: Ersan YAKIT <[email protected]> Date: Fri Mar 24 06:03:56 2023 +0300 typo: fix Merkel to Merkle(#1120) commit 390bbe69c156a82211ad6eafb6e295c703ac89c9 Author: Leon <[email protected]> Date: Fri Mar 24 10:42:18 2023 +0800 miner: add fallthrough for switch cases (#1377) commit c9a679a383105f9ae20e24c3f3843604b45530ea Author: Larry <[email protected]> Date: Fri Mar 24 09:51:11 2023 +0800 fix: add some boundary check for security (#1354) commit 9ffd7e139ed620578765a8f327d9a484e49ab868 Author: buddh0 <[email protected]> Date: Wed Mar 22 13:42:25 2023 +0800 clean: reduce useless logs commit a32a7b1cf70b1b869e63a8553adeb4bd1df9dfd4 Author: buddh0 <[email protected]> Date: Tue Mar 21 20:03:14 2023 +0800 tracer: enable withLog for TraceCall commit 33590ce2e93aad80e0d34ddcb35162b22c880d0b Author: Nathan <[email protected]> Date: Thu Mar 23 10:39:20 2023 +0800 ci: fix truffle test (#1384) commit fc4303c6c601a697bc1d1f9da17e11c556c6dba1 Author: Larry <[email protected]> Date: Wed Mar 15 18:06:00 2023 +0800 fix: crash on nil access when TxPool shutdown (#1353) (#1356) commit b99ef2541f098d522e30ca7df58b27987a4b3998 Author: Larry <[email protected]> Date: Wed Mar 15 17:43:18 2023 +0800 fix: crash on nil access when TxPool shutdown (#1353) commit 8bd6ee887bc7e1e455c0ee78b445f3096104173f Merge: 0d87a13c9 9b4f10692 Author: Larry <[email protected]> Date: Wed Mar 15 12:24:55 2023 +0800 Merge pull request #1352 from brilliant-lx/remove_bep188 upgrade: remove BEP-188 from planck hardfork commit 7b6cebed7bb9a42c43c3b0b12413a83ef249d8e4 Merge: 9c1d2836a 9b4f10692 Author: Larry <[email protected]> Date: Tue Mar 14 21:54:30 2023 +0800 Merge pull request #1351 from brilliant-lx/remove_bep188 upgrade: remove BEP-188 from planck hardfork commit 9b4f10692baadff6019fba1e5a313046833907db Author: larry.lx <[email protected]> Date: Tue Mar 14 17:32:22 2023 +0800 doc: remove BEP-188 from planck commit 6526a601cbd11f4ba4247b2c2f553f9ae211b8a2 Author: larry.lx <[email protected]> Date: Tue Mar 14 17:29:35 2023 +0800 Revert "parlia: consensus changes according to BEP of Early Broadcast (#1268)" This reverts commit f5cb1378da878146a6b3402e7ce9f53783e4f977. commit 540adff8be6a93bae457130645ae7d4d7bba2703 Author: larry.lx <[email protected]> Date: Tue Mar 14 17:22:49 2023 +0800 Revert "parlia: miner changes for BEP-188 of Early Broadcast (#1269)" This reverts commit c8a1535c74152c8e91eca2d4dfeb914ffb02ba18. commit 9c1d2836ae62bfb85a34fe1c2afcfe8429cf1dba Merge: 6587671e7 0d87a13c9 Author: Larry <[email protected]> Date: Tue Mar 14 12:29:22 2023 +0800 Merge pull request #1350 from bnb-chain/develop release: draft release v1.1.20 commit 0d87a13c946020fad5dfcb44a0f6fe8d30f2d9b0 Author: Larry <[email protected]> Date: Tue Mar 14 10:40:26 2023 +0800 release: prepare for release v1.1.20 (#1349) commit 22645261bfd9830267cf247444e794b3267dbe36 Author: Eric <[email protected]> Date: Mon Mar 13 21:16:00 2023 +0800 core/txpool: implement additional DoS defenses (#1348) Co-authored-by: Marius van der Wijden <[email protected]> commit 36ccd334be64d8709c23c5e95ad3dc807c7a358c Author: Larry <[email protected]> Date: Mon Mar 13 21:02:05 2023 +0800 upgrade: update the fork height of planck upgrade on testnet (#1347) commit c1fde0e86c93f2b825c9b4aa4749817d4fdc182b Author: Leon <[email protected]> Date: Mon Mar 13 11:10:16 2023 +0800 consensus: fix delete the 1st validator from snapshot.recents list (#1344) * consensus: fix delete the 1st validator from snapshot.recents list * consensus:fix uint sub error with negative commit c11431e4ea49740677102dccc7d703c2efdb093b Author: Roshan <[email protected]> Date: Fri Mar 10 11:20:39 2023 +0800 upgrade: update system contracts' code of planck upgrade (#1343) commit a476e315f23878e1bf6cb901cba7ce307e08c69c Author: Larry <[email protected]> Date: Tue Mar 7 09:59:03 2023 +0800 rename: change the next upgrade name to Planck (#1339) commit a9560646297fb3ef92df2d79b5de205b46b15856 Author: blxdyx <[email protected]> Date: Mon Mar 6 19:53:13 2023 +0800 clean: Remove support for Ethereum testnet (#1337) commit a671641e75bf3347da99e0a7a01b44438fcabfc1 Author: yutianwu <[email protected]> Date: Mon Mar 6 08:38:39 2023 +0800 sec: add proof ops check and key checker (#1333) commit 85d1237c33f86f15624f192aca889a0c936649b9 Author: Larry <[email protected]> Date: Fri Mar 3 17:02:44 2023 +0800 refactor: code of func backOffTime() (#1329) * consensus: refactor the code in func backOffTime() * update: more efficient code * fix: a slice bug commit 109a8e73f725aad25373b6e4e605aef2662cf604 Author: Roshan <[email protected]> Date: Wed Mar 1 20:17:18 2023 +0800 upgrade: update system contracts' code of testnet (#1328) commit c8a1535c74152c8e91eca2d4dfeb914ffb02ba18 Author: kyrie-yl <[email protected]> Date: Wed Mar 1 16:57:42 2023 +0800 parlia: miner changes for BEP-188 of Early Broadcast (#1269) commit 2a76eb498d1ecf0164b189e46e4c07d5ef581a2d Author: Leon <[email protected]> Date: Wed Mar 1 16:47:38 2023 +0800 consensus: fix slash bug when validator set changing (#1162) commit d065c4859ec2e84cd08e74f35185c961a21613f1 Author: yutianwu <[email protected]> Date: Wed Mar 1 15:49:05 2023 +0800 feats: add ics23 proof support for cross chain packages (#1149) commit f5cb1378da878146a6b3402e7ce9f53783e4f977 Author: kyrie-yl <[email protected]> Date: Tue Feb 28 19:53:17 2023 +0800 parlia: consensus changes according to BEP of Early Broadcast (#1268) commit 13fdb9b3654ae9ab20ff0b8b4130ff12dba5c33f Author: can <[email protected]> Date: Tue Feb 28 11:16:17 2023 +0800 tracer: port call tracer `withLog` to bsc (#1261) commit 217e474cc6842aa0c7372171163922b3380011da Author: blxdyx <[email protected]> Date: Tue Feb 28 09:47:51 2023 +0800 cmd/utils/flags.go: --diffsync flag is deprecate. (#1322) commit 6587671e748805a438c4c617e766ce168a38e5e6 Author: dylanhuang <[email protected]> Date: Mon Feb 13 14:13:00 2023 +0800 fix: Dockerfile (#1312) commit 5d696b940a9c70c16bb2d8fc80709cd6bdf945b6 Merge: ad81821ad 175db6b8d Author: dylanhuang <[email protected]> Date: Mon Feb 13 13:51:52 2023 +0800 Merge pull request #1311 from bnb-chain/develop release: draft release v1.1.19 commit 175db6b8d4fc6dc70094a0976918ca129a825eb4 Merge: b3a20c761 eafd33c38 Author: dylanhuang <[email protected]> Date: Mon Feb 13 11:40:48 2023 +0800 Merge pull request #1310 from j75689/p_v1.1.19 release: prepare for release v1.1.19 commit eafd33c3872f23aa0a4d060fbcfc08eb4d1d7735 Merge: 8192eafbf ad81821ad Author: j75689 <[email protected]> Date: Mon Feb 13 10:49:07 2023 +0800 fix: conflict with master branch commit 8192eafbf6ae3da082c737893c2b9c1cc43b7763 Author: j75689 <[email protected]> Date: Mon Feb 13 10:38:13 2023 +0800 release: prepare for release v1.1.19 commit b3a20c7611ccffcf7002c35cb5b61dda961f4c95 Author: setunapo <[email protected]> Date: Thu Feb 9 22:01:44 2023 +0800 fix: p2p sync with lagging peer (#1301) * fix: p2p sync with lagging peer no need to sync with lagging peer, which could make the local chain stalling as well. * fix: do not drop lagging peer, will retry it later. The lagging peer is probably already the best peer with largest total difficulty. Shoule not remove it, since p2p is a bidirectional connection, drop it could make the peer unable to sync with this peer as well. And the lagging peer could catch up later, so keep it. * p2p: add lagging field in Peer lagging peer will be connected, but won't be used to sync. the lagging flag can be clear once the Peer updates its latest block state. * test: fix UT compile issue * fix: lagging peer func rename * test: fix a UT fail of download test errStallingPeer is replaced by errLaggingPeer in this case * fix: lagging issue in light mode * test: add and resolve UT of lagging peer commit e4575c52a9f7a110c0bf971402bdb00625f30dbd Author: GalaIO <[email protected]> Date: Tue Feb 7 19:29:40 2023 +0800 eth/fetcher: fix re-queue failed issue; commit c9bd677b9115a5773d5a35570aee71982ccf2c03 Author: dylanhuang <[email protected]> Date: Fri Feb 3 17:38:20 2023 +0800 dep: update tendermint to v0.31.14 (#1298) commit ad81821ad96305256f769339bd9718b674908f54 Author: Andre Schreder <[email protected]> Date: Fri Feb 3 08:53:57 2023 +0100 docker: update bind-tools version (#1271) commit e2e1147a41951d378de9ba50e3f2e361f8ae1212 Author: dylanhuang <[email protected]> Date: Fri Feb 3 15:53:36 2023 +0800 mointor: implement double sign monitor (#1199) commit 7674814036f18c4d58ffcd93fd7392d9f3ab865b Author: Eric <[email protected]> Date: Thu Feb 2 19:48:47 2023 +0800 parlia : add a check for the length of extraData. (#1294) * parlia : add a check for the length of extraData. commit bf68be2bd970220bda611bc139ec425551391a20 Author: dylanhuang <[email protected]> Date: Thu Feb 2 19:36:37 2023 +0800 dep: bump the version of several important library (#1274) * dep: upgrade secp256k1 to use btcec/v2 v2.3.2 and update insecurity pkg * build ci: upgrade go to 1.19 and golangci-lint to 1.50.1 * docs: fix format that does not follow the goimports * dep: redirect github.com/bnb-chain/tendermint to v0.31.13 * ci: disable GOPROXY commit 176ab95ee518c5fb20e756bb1b909cb52da3e143 Author: j75689 <[email protected]> Date: Wed Dec 28 15:10:46 2022 +0800 ci: disable CGO_ENABLED when building binary commit 0f744c7f7369f7dc08949c198fe70e92956f7d23 Author: Ng Wei Han <[email protected]> Date: Wed Feb 1 11:34:16 2023 +0800 docs: minor fix on geth links (#1287) commit d22153b9da00076d6d590d521f11691879217fba Author: zjubfd <[email protected]> Date: Fri Jan 6 10:51:57 2023 +0800 docs: minor fix about the readme (#1267) commit b34453e3eb27ab756244f29e9d570769e58763e1 Author: zjubfd <[email protected]> Date: Thu Jan 5 18:41:46 2023 +0800 docs: update the readme (#1266) commit 8362242de6dcb3578cd6241e02365fe5b79ab077 Author: j75689 <[email protected]> Date: Thu Dec 22 16:56:48 2022 +0800 build: fix windows compilation failure commit b37d44b2896afc8784c5370b7cf247f2e15c6d68 Author: j75689 <[email protected]> Date: Thu Dec 22 16:47:43 2022 +0800 ci: update unmaintained tools to use maintained tools commit 30369897f2cd3997013ce407dec26b382392ec7e Author: joeycli <[email protected]> Date: Tue Dec 20 09:40:01 2022 +0800 fix comments: prune ancient compatibility, add prune ancient comments commit 154f339ce3a39cbf97215637c80fe1f28a2b06fe Author: WayToFuture <[email protected]> Date: Thu Dec 22 12:39:36 2022 +0800 comments: add comments to clarify flags and byte codes (#1245) commit e9a04cca302a9e122ca867d73b1ead30388d4c22 Author: Seungbae Yu <[email protected]> Date: Thu Aug 4 00:02:09 2022 +0900 core: preallocate batch size in bloomIndexer (#25289) This change reduces allocations when committing bloombits indexes by creating the database batch with a larger initial size. commit da977e9cdcca9ebb969f531401bdf2b467930928 Author: rjl493456442 <[email protected]> Date: Tue Feb 15 21:15:13 2022 +0800 core, ethdb, tests, trie: implement NewBatchWithSize API for batcher (#24392) This PR adds an addtional API called `NewBatchWithSize` for db batcher. It turns out that leveldb batch memory allocation is super inefficient. The main reason is the allocation step of leveldb Batch is too small when the batch size is large. It can take a few second to build a leveldb batch with 100MB size. Luckily, leveldb also offers another API called MakeBatch which can pre-allocate the memory area. So if the approximate size of batch is known in advance, this API can be used in this case. It's needed in new state scheme PR which needs to commit a batch of trie nodes in a single batch. Implement the feature in a seperate PR. commit cc17abfa17afbb8439ffdfb0ce45c846b7fe6fdf Author: dylanhuang <[email protected]> Date: Fri Dec 16 07:59:16 2022 +0800 metrics: add miner info into metrics server (#1212) * metrics: add unlock address to metrics when miner module is enabled * metrics: add miner config into metrics server * metrics: add device-info into metrics server * metrics: fix the format of device info * metrics: remove device-info commit c5b7d747f7baf50535006d4d151038f67dd04125 Author: kyrie-yl <[email protected]> Date: Tue Dec 13 17:16:14 2022 +0800 eth, trie: sync with upstream v1.10.26 to solve snap sync issues (#1226) * eth: fix a rare datarace on CHT challenge reply / shutdown * trie: check childrens' existence concurrently for snap heal * eth/protocols/snap: fix problems due to idle-but-busy peers * eth/filters: change filter block to be by-ref (#26054) This PR changes the block field in the filter to be a pointer, to disambiguate between empty hash and no hash * rpc: handle wrong HTTP batch response length (#26064) * eth/protocols/snap: throttle trie heal requests when peers DoS us (#25666) * eth/protocols/snap: throttle trie heal requests when peers DoS us * eth/protocols/snap: lower heal throttle log to debug Co-authored-by: Martin Holst Swende <[email protected]> * eth/protocols/snap: fix comment Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]> Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Jordan Krage <[email protected]> commit b4773e8b5080f37e1c65c083b543f60c895abb70 Author: Eric <[email protected]> Date: Thu Dec 8 14:20:39 2022 +0800 doc: update README (#1234) commit 8894b6559045fc6bf52c7ef3d268ab617b0bb4c1 Author: setunapo <[email protected]> Date: Wed Dec 7 14:59:37 2022 +0800 doc: update readme (#1233) commit cb9e50bdf62c6b46a71724066d39f9851181a5af Merge: 03ff2992a cd0d177f5 Author: zjubfd <[email protected]> Date: Thu Dec 1 17:12:31 2022 +0800 Merge pull request #1223 from bnb-chain/develop hotfix: fix the incorrect format of prometheus label commit cd0d177f57642e10f8f335f7cfaff84010ff6608 Merge: b6b274eba ecc12f649 Author: zjubfd <[email protected]> Date: Thu Dec 1 17:07:09 2022 +0800 Merge pull request #1222 from j75689/fix/build-info metrics: fix the label format of prometheus server commit ecc12f6493665f5b2619f57e5d5f4d331159e529 Author: j75689 <[email protected]> Date: Thu Dec 1 16:54:10 2022 +0800 metrics: fix the label format of prometheus server commit b6b274eba2ec4dc5683b38c2e8e45b1c2ceb0f3f Author: nathanhopp <[email protected]> Date: Wed Nov 30 19:13:50 2022 -0700 metrics fix: edit mutate key to replace - with _ (#1217) commit 03ff2992ab4674c1df8f568ee9a31596f3503c26 Merge: 790f6e767 d3873f4cc Author: zjubfd <[email protected]> Date: Tue Nov 29 15:46:26 2022 +0800 Merge pull request #1211 from bnb-chain/develop release: draft release v1.1.18 commit d3873f4ccfa3897f6bdef67aa441280df2caa757 Merge: ef16f9efd 02f7ad74c Author: zjubfd <[email protected]> Date: Tue Nov 29 15:07:01 2022 +0800 Merge pull request #1210 from guagualvcha/p_1.1.18 release: prepare for v1.1.18 release. commit 02f7ad74c6829ba8040c9afc8cdfab07d9df14e5 Author: zjubfd <[email protected]> Date: Tue Nov 29 13:39:08 2022 +0800 release: prepare for release v1.1.18 commit ef16f9efdb79c4dc3260338d415d6ed473a02e71 Merge: 807d52e55 fe5682c4e Author: dylanhuang <[email protected]> Date: Tue Nov 29 10:32:21 2022 +0800 Merge pull request #1209 from j75689/metrics/build-info metrics: add build info into metrics server commit fe5682c4e0f18e9d3e7117006504e28913f59f88 Author: j75689 <[email protected]> Date: Mon Nov 28 22:38:59 2022 +0800 ci: fix build cmd of arm binary commit d1c9262b123cbbc17438f12e6986617b740e4721 Author: j75689 <[email protected]> Date: Mon Nov 28 22:20:54 2022 +0800 ci: add git info to cross-compile commit 9023e42d0a1851e427f35331546444599b4915a0 Author: j75689 <[email protected]> Date: Mon Nov 28 22:09:45 2022 +0800 metrics: add build info into metrics server commit d77ebb8511e04859bb77bed95054ce59b024039f Author: j75689 <[email protected]> Date: Mon Nov 28 22:09:27 2022 +0800 metrics: add label type in metrics package commit 807d52e5577bcf9bcb33abb5d39dcf25e00aed99 Author: setunapo <[email protected]> Date: Fri Nov 25 17:46:22 2022 +0800 worker: some Subscribe NewTxsEvent changes of miner worker 1.remove the unnecessary NewTxsEvent subscriber, which was used for PoW resubmit check. 2.unsubscribe ASAP before another fillTransactions, to avoid block others. commit 58644491ada8b7f791ecbc73d06bf00fcf3b759d Author: setunapo <[email protected]> Date: Fri Nov 25 14:05:19 2022 +0800 worker: reused triePrefetch when multi-fillTransactions to mine a block. avoid too much trie prefetch routines when several fillTransactions are called. commit d87d697d927c9dd0d24ee31e15b23e0f760469fa Author: Larry <[email protected]> Date: Thu Nov 24 15:22:37 2022 +0800 worker: add double sign check for safety. (#1201) * worker: add double sign check for safety. And for corner cases, such as reorg after reorg... use slice to record all broadcast blocks's parents to avoid overwritten. commit 90a414ab7c443bbe848e984fe84717935dfd0a4b Merge: aa986b6d4 db4cb1df2 Author: Roshan <[email protected]> Date: Tue Nov 22 16:29:03 2022 +0800 Merge pull request #1195 from Pythonberg1997/cross_stake update Gibbs fork height and system contract code commit db4cb1df261032b165de5078dc43d86801e30659 Author: Roshan <[email protected]> Date: Mon Nov 21 19:42:35 2022 +0800 upgrade: update Gibbs fork height and system contract code commit aa986b6d4e930ee5a441932aeb939bff973ec19e Author: setunapo <[email protected]> Date: Mon Nov 21 13:30:57 2022 +0800 worker: return for resubmit signal. it is not necssary to add more transaction when resubmit is fired. the resubmit logic was for PoW and can be removed later. commit 21b985c14b32aef35c5411e2f38d731852bff934 Author: setunapo <[email protected]> Date: Fri Nov 18 22:55:17 2022 +0800 worker: always drop on new block imported. When new block is imported, there is no need to commit the current work, even the new imported block is offturn and itself is inturn. That is because when offturn block is received, the inturn block is already later to broadcast block, deliver the later block will cause many reorg, which is not reasonable. And also make sure all useless work can be discarded, to avoid goroutine leak. commit c33f696811f661e7d374c9e1b414e75f2bebd5ed Author: setunapo <[email protected]> Date: Thu Nov 17 15:38:50 2022 +0800 worker: do not fillTransactions immediately on new transaction. It may not efficient if schedule fillTransactions when new transactions arrive. It could make the CPU keep running. To make is more efficient: 1.schedule fillTransactions when a certain amount of transaction are arrived. 2.or there is not much time left. commit de5dd95ada73be53853568ee7b1a385c0fd3edea Author: setunapo <[email protected]> Date: Fri Oct 28 12:01:18 2022 +0800 worker: enhancement of the current block generation logic. Currently, validator only try once to get transactions from TxPool to produce the block. However, new transactions could arrive while the validator is committing transaction. Validator should be allowed to add these new arrived transactions as long as Header.Timestamp is not reached This commit will: ** commitTransactions return with error code ** drop current mining block on new block imported ** try fillTransactions several times for the best not use append mode to follow the GasPrice rule. ** check if there is enough time for another fillTransactions. commit 276b69ee8bffe6df503cdfa03414a2bcf25edc1e Merge: dbc70ee1e fb2e68b79 Author: zjubfd <[email protected]> Date: Sun Nov 20 15:20:09 2022 +0800 Merge pull request #1192 from kyrie-yl/upstream_v1.10.22 all: sync with upstream v1.10.22 commit fb2e68b79a65eb24931c56fbeb2d2916468bbf46 Author: Henry <[email protected]> Date: Mon Aug 1 19:47:21 2022 +0800 common/compiler: json unmarshalling error checks (#25449) complier/solidity:add json.Unmarshal err check commit 48b6db9f636ff8885c2963a30ea49448e1fe6268 Author: ycyraum <[email protected]> Date: Fri Aug 12 13:58:06 2022 +0200 core/genesis: remove calaverasAllocData (#25516) core/genesis: calaverasAllocData no longer used commit 466e9a2a3d80ceaf0aab22d4edf0ba0a55812fe8 Author: rjl493456442 <[email protected]> Date: Fri Aug 19 06:39:47 2022 +0800 trie: improve node rlp decoding performance (#25357) This avoids copying the input []byte while decoding trie nodes. In most cases, particularly when the input slice is provided by the underlying database, this optimization is safe to use. For cases where the origin of the input slice is unclear, the copying version is retained. The new code performs better even when the input …

ngotchac changed the title ~~Fix invalid merkle root panic in tests~~ Fix some flaky tests Mar 22, 2023

buddh0 requested review from buddh0 and j75689 March 31, 2023 02:41

galaio changed the base branch from master to develop March 31, 2023 03:52

brilliant-lx reviewed Apr 2, 2023

View reviewed changes

core/blockchain.go Show resolved Hide resolved

brilliant-lx reviewed Apr 2, 2023

View reviewed changes

core/state/statedb.go Show resolved Hide resolved

ngotchac added 3 commits April 3, 2023 09:11

core/state: Remove prefetcher on stop

f911e2e

core/blockchain: Wait for triedb.Dereference in writeBlockWithState

efed1ac

eth/protocols/diff: Fix index mismatch in TestGetDiffLayers

12c5733

ngotchac force-pushed the ngotchac/fix-tests-panic branch from e51f8f5 to 12c5733 Compare April 3, 2023 07:15

This comment was marked as abuse.

Sign in to view

galaio approved these changes Apr 3, 2023

View reviewed changes

brilliant-lx approved these changes Apr 3, 2023

View reviewed changes

brilliant-lx merged commit 221ef7d into bnb-chain:develop Apr 3, 2023

This was referenced Apr 7, 2023

release: prepare for release v1.1.22 #1418

Merged

release: draft release v1.1.22 #1423

Merged

ngotchac deleted the ngotchac/fix-tests-panic branch April 11, 2023 08:19

This was referenced Apr 14, 2023

fix: panic on using WaitGroup after it is freed. #1464

Merged

release: prepare for release v1.1.23 #1474

Merged

DarianShawn mentioned this pull request Apr 20, 2023

core: fix some flaky tests dogechain-lab/dbsc#10

Merged

0xcb9ff9 mentioned this pull request Apr 20, 2023

fix: panic on using WaitGroup after it is freed (#1464) dogechain-lab/dbsc#13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some flaky tests #1379

Fix some flaky tests #1379

ngotchac commented Mar 22, 2023

ngotchac commented Mar 22, 2023

galaio commented Mar 31, 2023 •

edited

Loading

qinglin89 commented Apr 2, 2023 •

edited

Loading

ngotchac commented Apr 3, 2023

galaio commented Apr 3, 2023

ngotchac commented Apr 3, 2023

This comment was marked as abuse.

Fix some flaky tests #1379

Fix some flaky tests #1379

Conversation

ngotchac commented Mar 22, 2023

Description

Rationale

ngotchac commented Mar 22, 2023

galaio commented Mar 31, 2023 • edited Loading

qinglin89 commented Apr 2, 2023 • edited Loading

ngotchac commented Apr 3, 2023

galaio commented Apr 3, 2023

ngotchac commented Apr 3, 2023

This comment was marked as abuse.

galaio commented Mar 31, 2023 •

edited

Loading

qinglin89 commented Apr 2, 2023 •

edited

Loading