Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts: fix duplicate field names in the generated go struct #1139

Merged

Conversation

qinglin89
Copy link
Contributor

@qinglin89 qinglin89 commented Oct 16, 2022

Description

Sync with go-ethereum:

This pr fixes the problem of duplicate field names in go struct generated by abigen. The fix is to add numbers after the duplicate field names.
Related issue: ethereum/go-ethereum#24627

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • accounts/abi/bind: fix duplicate field names in the generated go struct #24627

  • accounts, cmd/abigen: resolve name conflicts

  • ci lint, accounts/abi: remove unused function overloadedArgName

…ct (#24924)

* accounts/abi/bind: fix duplicate field names in the generated go struct #24627

* accounts, cmd/abigen: resolve name conflicts

* ci lint, accounts/abi: remove unused function overloadedArgName

Co-authored-by: Gary Rong <[email protected]>
@brilliant-lx brilliant-lx added the r4r ready for review label Oct 21, 2022
@brilliant-lx brilliant-lx merged commit c93b905 into bnb-chain:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants