fix: upstream patches #1076
Merged
fix: upstream patches #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the evm json output less verbose: omitting output of `memory` and `returndata` in case they are empty.
…d of error (#24475) * core: Change Snapshot extension registration failed to Debug * Update eth/handler.go Co-authored-by: Martin Holst Swende <[email protected]>
"miner" is not set for pending block responses in some cases. Fixes #24632
This PR fixes a few panics in the chain marker benchmarks. The root cause for panic is in chain marker the genesis header/block is not accessible, while it's expected to be obtained in tests. So this PR avoids touching genesis header at all to avoid panic.
…l (#24663) This change removes extraneous/unnecessary checks for equality when comparing 2 accessList values A and B. Given that we validate that their lengths of A and B are equal, if so and if every element in A is in B, reflexively every element in B is already in A. If that weren't the case and an element g existed in A but not in B, that would mean that there is an extra element and hence a mathematical contradiction. Fixes #24658
* cmd/evm: ensure input length is even * cmd/evm: minor nit + lintfix Co-authored-by: Martin Holst Swende <[email protected]>
It was 'int' accidentally, should be DiscReason instead.
Storage proofs were being unmarshalled from the RPC form to the go struct, but were not being included in the final returned struct.
This PR improves the docker build speed for repeated builds where go.mod and go.sum do no change, by placing the downloaded dependencies in a lower layer
This PR doubles the limit on which to trigger automatic shutdown, and also changes the timer to run once every 30s instead of 60s.
Changed `log.Fatal` to `log.Fatalf()` as it has a parameter...
The loop label can be removed because this 'continue' statement is not in a nested loop.
Co-authored-by: Felix Lange <[email protected]>
* eth/fetcher: fix test to avoid hanging. Partial fix for #23331 * eth/filters: avoid dangling goroutines * eth/fetcher: revert closing of proceed
This PR fixes abi checks in the edge case where all arguments are indexed
Fixes three race conditions found through fuzzing by David Theodore
reverse the order of address in queue
|
LGTM |
unclezoro
approved these changes
Sep 6, 2022
brilliant-lx
reviewed
Sep 7, 2022
brilliant-lx
approved these changes
Sep 7, 2022
This was referenced Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pick some patches from
go-ethereumon v1.10.18， mainly including some bug fixes, and would submit some separateprsfor left related patches about features/performance.follow with #1061
Rationale
N/A
Example
N/A
Changes
Notable changes: