[R4R] fix: Incorrect merkle root issue when enabling pipecommit with miner #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pipecommit
with miner.2. Account root hash is incorrect when doing `statedb.CorrectAccountsRoot `.
Rationale
parlia
consensus will call the system contract inFinalizeAndAssemble
, and change the state of the world. But before that, thestatedb
is copied, but this copiedstatedb
will not be used when writing blocks, resulting in incorrect writing of the world state.account root
is an empty hash, the correctemptyhash
value is not assigned.Example
N/A
Changes
Notable changes:
statedb
afterFinalizeAndAssemble