internal/api: return empty array rather than nil (#2385)

bnb-chain · Apr 10, 2024 · 009df5a · 009df5a
1 parent d7836bf
commit 009df5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -1018,7 +1018,7 @@ func (s *BlockChainAPI) GetBlobSidecars(ctx context.Context, blockNrOrHash rpc.B
 		return nil, nil
 	}
 	blobSidecars, err := s.b.GetBlobSidecars(ctx, header.Hash())
-	if err != nil || len(blobSidecars) == 0 {
+	if err != nil || blobSidecars == nil {
 		return nil, nil
 	}
 	result := make([]map[string]interface{}, len(blobSidecars))
@@ -1040,7 +1040,7 @@ func (s *BlockChainAPI) GetBlobSidecarByTxHash(ctx context.Context, hash common.
 		return nil, nil
 	}
 	blobSidecars, err := s.b.GetBlobSidecars(ctx, blockHash)
-	if err != nil || len(blobSidecars) == 0 {
+	if err != nil || blobSidecars == nil || len(blobSidecars) == 0 {
 		return nil, nil
 	}
 	for _, sidecar := range blobSidecars {

diff --git a/internal/ethapi/testdata/eth_getBlobSidecars-block-with-blob-tx.json b/internal/ethapi/testdata/eth_getBlobSidecars-block-with-blob-tx.json
@@ -1 +1 @@
-null
+[]