Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 #562

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 #562

merged 1 commit into from
Jul 22, 2024

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented May 22, 2024 •
edited by buddh0
Loading

Description

feat: define turnLength and systemRewardAntiMEVRatio for BEP-341

Rationale

tell us why we need these changes...

Example

two tests will pass by following command

cd contracts 
forge test --match-test testDeposit --match-contract ValidatorSetTest
forge test --match-test testGov --match-contract ValidatorSetTest

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 8e9c8d2 to 643e917 Compare May 22, 2024 07:29
@NathanBSC NathanBSC changed the base branch from master to fix_part_unit_tests May 22, 2024 07:29
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from 643e917 to ebefd4c Compare May 22, 2024 08:06
@NathanBSC NathanBSC changed the title BEP-341: define turnTerm and antiMEVSystemRewardRatio feat: define turnTerm and antiMEVSystemRewardRatio for BEP-341 May 22, 2024
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch 3 times, most recently from 5f15782 to a977759 Compare May 29, 2024 03:15
@NathanBSC NathanBSC changed the title feat: define turnTerm and antiMEVSystemRewardRatio for BEP-341 feat: define turnTerm and systemRewardAntiMEVRatio for BEP-341 May 29, 2024
@buddh0 buddh0 force-pushed the BEP-341-produce-consecutive-blocks branch from a977759 to 9848397 Compare June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from fix_part_unit_tests to develop June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from develop to master June 3, 2024 08:24
@buddh0 buddh0 changed the base branch from master to develop June 3, 2024 08:32
@buddh0 buddh0 changed the base branch from develop to master June 3, 2024 08:42
@buddh0 buddh0 changed the base branch from master to develop June 3, 2024 12:54
@buddh0 buddh0 marked this pull request as ready for review June 3, 2024 12:54
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch 2 times, most recently from 720f5b6 to f9d1a0c Compare June 28, 2024 01:43
@buddh0 buddh0 changed the title feat: define turnTerm and systemRewardAntiMEVRatio for BEP-341 feat: define turnLength and systemRewardAntiMEVRatio for BEP-341 Jun 28, 2024
@NathanBSC NathanBSC mentioned this pull request Jul 16, 2024
Merged
@unclezoro unclezoro closed this Jul 16, 2024
@buddh0 buddh0 reopened this Jul 17, 2024
@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from f9d1a0c to f26053c Compare July 17, 2024 02:15
@NathanBSC
Copy link
Contributor Author

NathanBSC commented Jul 17, 2024 •
edited
Loading

force push after rebase develop 07.17

@NathanBSC NathanBSC force-pushed the BEP-341-produce-consecutive-blocks branch from f26053c to d451f6d Compare July 18, 2024 07:44
@buddh0
Copy link
Contributor

buddh0 commented Jul 18, 2024

force push after rebase develop 07.18

zzzckck
zzzckck approved these changes Jul 22, 2024
View reviewed changes
Copy link

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTN, but pls make sure, the community can understand the change of the SystemRewardRatio part.

@unclezoro unclezoro merged commit 1934266 into bnb-chain:develop Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emailtovamos emailtovamos emailtovamos left review comments

@buddh0 buddh0 buddh0 left review comments

@zzzckck zzzckck zzzckck approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NathanBSC @buddh0 @unclezoro @emailtovamos @zzzckck