Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clevel db configuration on newApp #85

Closed
ackratos opened this issue Mar 14, 2019 · 1 comment
Closed

clevel db configuration on newApp #85

ackratos opened this issue Mar 14, 2019 · 1 comment
Assignees
@ackratos
Labels
bug Something isn't working

Comments

@ackratos
Copy link
Contributor

currently newApp depends on openDB hard coded go level db implementation:

func openDB(rootDir string) (dbm.DB, error) {
	dataDir := filepath.Join(rootDir, "data")
	db, err := dbm.NewGoLevelDB("application", dataDir)
	return db, err
}

we need pick up cosmos changes they recently merged: cosmos/cosmos-sdk#3792 if we want switch to cleveldb
@ackratos ackratos self-assigned this Mar 14, 2019
@ackratos ackratos added the bug Something isn't working label Mar 14, 2019
ackratos added a commit that referenced this issue Mar 15, 2019
@ackratos
#85 application db should not bound to goleveldb implementation
eb8fa38
@ackratos ackratos mentioned this issue Mar 18, 2019
Merged
ackratos added a commit that referenced this issue Mar 18, 2019
@ackratos
Merge pull request #87 from binance-chain/issue85
ec36057 
[R4R] #85 application db should not bound to goleveldb implementation
@ackratos
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ackratos ackratos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ackratos