Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs to say that the Dockerfile is created, not the image #1210

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix docs to say that the Dockerfile is created, not the image #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/docs/asciidoc/user-guide/23-tasks.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The plugin provides a set of tasks for your project and preconfigures them with
|=======
|Task name |Depends On |Type |Description
|`dockerSyncBuildContext` |`classes` |TaskProvider<{uri-gradle-docs}/javadoc/org/gradle/api/tasks/Sync.html[Sync]> |Copies the application files to a temporary directory for image creation.
|`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the Docker image for the Java application.
|`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the `Dockerfile` for the Java application.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the same change in 33-tasks.adoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, commit amended and force-pushed.

|`dockerBuildImage` |`dockerCreateDockerfile` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/DockerBuildImage.html[DockerBuildImage]> |Builds the Docker image for the Java application.
|`dockerPushImage` |`dockerBuildImage` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/DockerPushImage.html[DockerPushImage]> |Pushes created Docker image to the repository.
|=======
2 changes: 1 addition & 1 deletion src/docs/asciidoc/user-guide/33-tasks.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The plugin provides a set of tasks for your project and preconfigures them with
|=======
|Task name |Depends On |Type |Description
|`dockerSyncBuildContext` |`classes` |TaskProvider<{uri-gradle-docs}/javadoc/org/gradle/api/tasks/Sync.html[Sync]> |Copies the application files to a temporary directory for image creation.
|`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the Docker image for the Spring Boot application.
|`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the `Dockerfile` for the Spring Boot application.
|`dockerBuildImage` |`dockerCreateDockerfile` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/DockerBuildImage.html[DockerBuildImage]> |Builds the Docker image for the Spring Boot application.
|`dockerPushImage` |`dockerBuildImage` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/DockerPushImage.html[DockerPushImage]> |Pushes created Docker image to the repository.
|=======