Fail build upon error with push operation

[MarkRx]

Fixes DockerPushImage task not failing when pushing fails

closes #1178

[bmuschko]

Can you add a task for add a task for removing the container image after the push. You will also need to add a pull task to ensure that the container image is available before use. It's possible that your test case runs first and the image may not exist yet.

task removeImage(type: DockerRemoveImage) {
     dependsOn buildImage
     mustRunAfter pushImage, pullImage
     targetImageId buildImage.getImageId()
     force = true
}

[MarkRx]

👍

[bmuschko]

We should check for DockerClientException here. That's the one your are throwing from the callback.

[MarkRx]

API doesn't seem to provide access to that information. I updated this to follow other examples

[bmuschko]

Is there a way to get the root cause of this failure e.g. one that indicates that incorrect credentials were used?

[MarkRx]

It doesn't look like it. It's a copy of https://github.com/docker-java/docker-java/blob/ca8b8598297df5b62feb02f88e748abf02fb3610/docker-java-api/src/main/java/com/github/dockerjava/api/command/PushImageCmd.java#L53

[bmuschko]

Thanks a lot for changes. They'll go out with the next release of the plugin.