add title to input method #29
Conversation
|
How do I update my fork master to your master |
|
Go to the folder on your local device, from the command line.
|
input-method.php
Outdated
| @@ -5,6 +5,7 @@ | |||
| echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"; | |||
|
|
|||
| $searchType = $_REQUEST['Digits']; | |||
| $inputTitle = $_REQUEST['Title']; | |||
There was a problem hiding this comment.
There is already a "Title" configuration value. We should use that, but instead specify that we want to play the title here. Also you need to check to make sure this value is set to 1, otherwise it will bomb out.
$playTitle = isset($_REQUEST['PlayTitle']) ? $_REQUEST['PlayTitle'] : 0;There was a problem hiding this comment.
Be sure to also add the documentation of this feature in README.md.
input-method.php
Outdated
| @@ -14,7 +15,8 @@ | |||
| ?> | |||
| <Response> | |||
| <Gather numDigits="1" timeout="10" action="input-method-result.php?SearchType=<?php echo $searchType ?>" method="GET"> | |||
| <Say voice="<?php echo $voice; ?>" language="<?php echo $language; ?>"><?php echo $inputTitle ?></Say> | |||
There was a problem hiding this comment.
Since this is option, you should wrap this in an if block.
Per my previous comment pull the title from the respective configuration value.
input-method.php
Outdated
| @@ -5,6 +5,7 @@ | |||
| echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"; | |||
|
|
|||
| $searchType = $_REQUEST['Digits']; | |||
| $inputTitle = $_REQUEST['Title']; | |||
There was a problem hiding this comment.
Be sure to also add the documentation of this feature in README.md.
… well as updated readme
|
alright made those changes, and it works not sure if its pretty enough but it works. |
input-method.php
Outdated
| echo "<Say voice=\"" . $voice . "\" language=\"" . $language . "\">" . $GLOBALS['title'] . "</Say>"; | ||
| } | ||
| ?> | ||
|
|
There was a problem hiding this comment.
This looks good. The only thing would be to fix indentations. Notice how I try to keep things lined up for readability. https://github.com/radius314/yap/blob/master/meeting-search.php
There was a problem hiding this comment.
gotcha, thanks. im starting to get more of a grasp on this whole github, fork, push, pull, commit thing too I think.
|
Just tested, works good. |
would this work