-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting Issues #530
Comments
possibly related to #511 |
There was a bug related to recursively plot metrics. That will be delivered in Yap 4.0.0-beta6. I've not had a chance to parse through the rest of this yet. |
@EzraKuhr can you validate if this issue is fixed on beta6? |
@EzraKuhr can you validate if this issue is fixed on beta7? |
Closing this out. Please verify when you can. |
@dgershman Sorry for not paying attention to this. Please reopen this ticket. Looks like items 2 and 3 in OP are still unresolved on Yap 4.0.4. We have multiple areas requesting the reporting indicated in item 2. Reposting here:
|
Thank you Danny! Saw the snippets, and it seems to be exactly what we're looking for. |
Regarding item 2, unless you have a phone number tied to an area and it's "called" into, there will be no meeting lookup or JFT metrics. There is no logical way, that I can think of to associate these lookups to an ASC, as they aren't tied to one. If you have an example of a phone call made to an ASC-specific number and a meeting search or JFT was done, I can look into it specifically. Below is an example of an ASC number that does exactly what I described above: |
* zero level metrics support #530 * updating version info * lint fix
All areas in Florida and South Florida have their own number and the webhooks point an area's phone number to the area's service body in yap. We very much have a need for this. Have to collaborate to provide any information or access you need to assist with this. |
The feature should work, to provide this level of metrics for ASCs. I am noticing that there is a bug with metrics, but I haven't tracked it down yet. |
*happy to collaborate Ok, thank you for your hard work. |
Ok I think I have tracked down the issue with the metrics. Looks like a query issue that needs to be fixed, not a data loss issue. |
There are some fixes headed for yap 4.0.5 that should fix a bug with how PHP was scoping one of the variables that are used for reporting. The release will also deal with the bad data. |
It still looks like the meeting lookups and JFT metrics are missing. |
I'm not sure if you saw this comment from a few days ago #530 (comment). I hope that clarifies things. The issue is that your phone numbers for ASCs are set with override_service_body_config_id versus override_service_body_id. At this time of a call without this being set there is no way to know what the service body is. |
I did not see that. Are there any other factors to know before switching to that override instead? |
It will basically eliminate location lookups for finding volunteers. You can Provision a test number and set up webhooks to test it out. |
Got it. Thank you Danny! I alerted Michelle to my mistake. We will work on testing this and verifying that. |
You can try out 4.0.5-beta1 which should fix this. |
Fixes Available in 4.1.0-beta2 if you want to test. https://github.com/bmlt-enabled/yap/releases/tag/4.1.0-beta2 |
fixes released in 4.1.0 |
2a. When I select Florida Region (with/without "Select Recursively"), the graph is HYPER focused (x axis ticks are 1/2000th of a second) on Jan 16, 2021 (I think that was the first day I did some testing at the Regional level, though I think there may have been more since.
2b. When "Select Recursively" is off, the geographical map is hyper focused on the one data point, but the table is empty (even though there were 3 volunteer calls that day.
2c. When "Select Recursively" is on, the map and table populate with many many data points as expected. but not the plot graph which just shows the one.
The text was updated successfully, but these errors were encountered: