Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting Issues #530

Closed
EzraKuhr opened this issue Aug 13, 2021 · 24 comments
Closed

Reporting Issues #530

EzraKuhr opened this issue Aug 13, 2021 · 24 comments

Comments

@EzraKuhr
Copy link

  1. When I go to 'all' (with and without "Select Recursively" enabled) I see data points in the graph for only Meetings and JFT
    2a. When I select Florida Region (with/without "Select Recursively"), the graph is HYPER focused (x axis ticks are 1/2000th of a second) on Jan 16, 2021 (I think that was the first day I did some testing at the Regional level, though I think there may have been more since.
    2b. When "Select Recursively" is off, the geographical map is hyper focused on the one data point, but the table is empty (even though there were 3 volunteer calls that day.
    2c. When "Select Recursively" is on, the map and table populate with many many data points as expected. but not the plot graph which just shows the one.
  2. When I drill into an area, the volunteers data points are the only one that show in the plot graph and geo map. I have no data points for meetings or JFT.
  3. Days with zero data points dont seem to be accounted for, so looks like the baseline is y=1, not y=0. (Not sure if I explained this well, but basically the graph never hits zero when it should. The absence of data is just as important as its presence)

image
image
image
image

@pjaudiomv
Copy link
Collaborator

possibly related to #511

@dgershman
Copy link
Collaborator

There was a bug related to recursively plot metrics. That will be delivered in Yap 4.0.0-beta6. I've not had a chance to parse through the rest of this yet.

@dgershman
Copy link
Collaborator

@EzraKuhr can you validate if this issue is fixed on beta6?

@dgershman
Copy link
Collaborator

@EzraKuhr can you validate if this issue is fixed on beta7?

@dgershman
Copy link
Collaborator

Closing this out. Please verify when you can.

@EzraKuhr
Copy link
Author

EzraKuhr commented Mar 6, 2022

@dgershman Sorry for not paying attention to this. Please reopen this ticket. Looks like items 2 and 3 in OP are still unresolved on Yap 4.0.4. We have multiple areas requesting the reporting indicated in item 2. Reposting here:

  1. When I drill into an area, the volunteers data points are the only one that show in the plot graph and geo map. I have no data points for meetings or JFT.
  2. Days with zero data points dont seem to be accounted for, so looks like the baseline is y=1, not y=0. (Not sure if I explained this well, but basically the graph never hits zero when it should. The absence of data is just as important as its presence)
  3. New related issue: I called the helpline pictured today (3/6/22), and I see it in the call log, but not in the graph. The most recent point in the graph was the last helpline call on 2/26/22

Thank you
image
image
image

@dgershman
Copy link
Collaborator

@EzraKuhr first point, zero metrics, is addressed here #583

@EzraKuhr
Copy link
Author

Thank you Danny! Saw the snippets, and it seems to be exactly what we're looking for.

@dgershman
Copy link
Collaborator

dgershman commented Mar 16, 2022

Regarding item 2, unless you have a phone number tied to an area and it's "called" into, there will be no meeting lookup or JFT metrics.

There is no logical way, that I can think of to associate these lookups to an ASC, as they aren't tied to one.

If you have an example of a phone call made to an ASC-specific number and a meeting search or JFT was done, I can look into it specifically.

Below is an example of an ASC number that does exactly what I described above:

image

dgershman added a commit that referenced this issue Mar 16, 2022
* zero level metrics support #530

* updating version info

* lint fix
@EzraKuhr
Copy link
Author

All areas in Florida and South Florida have their own number and the webhooks point an area's phone number to the area's service body in yap. We very much have a need for this. Have to collaborate to provide any information or access you need to assist with this.

@dgershman
Copy link
Collaborator

The feature should work, to provide this level of metrics for ASCs. I am noticing that there is a bug with metrics, but I haven't tracked it down yet.

@EzraKuhr
Copy link
Author

*happy to collaborate

Ok, thank you for your hard work.

@dgershman
Copy link
Collaborator

Ok I think I have tracked down the issue with the metrics. Looks like a query issue that needs to be fixed, not a data loss issue.

@dgershman
Copy link
Collaborator

There are some fixes headed for yap 4.0.5 that should fix a bug with how PHP was scoping one of the variables that are used for reporting. The release will also deal with the bad data.

@dgershman
Copy link
Collaborator

#585

@dgershman
Copy link
Collaborator

Here is what the chart looks like for Space Coast Area. The last little spike is test data.

image

@EzraKuhr
Copy link
Author

EzraKuhr commented Apr 4, 2022

It still looks like the meeting lookups and JFT metrics are missing.

@dgershman
Copy link
Collaborator

dgershman commented Apr 4, 2022

I'm not sure if you saw this comment from a few days ago #530 (comment). I hope that clarifies things. The issue is that your phone numbers for ASCs are set with override_service_body_config_id versus override_service_body_id. At this time of a call without this being set there is no way to know what the service body is.

@EzraKuhr
Copy link
Author

EzraKuhr commented Apr 4, 2022

I did not see that. Are there any other factors to know before switching to that override instead?

@mczelusniak

@dgershman
Copy link
Collaborator

It will basically eliminate location lookups for finding volunteers. You can Provision a test number and set up webhooks to test it out.

@EzraKuhr
Copy link
Author

EzraKuhr commented Apr 4, 2022

Got it. Thank you Danny! I alerted Michelle to my mistake. We will work on testing this and verifying that.

@dgershman
Copy link
Collaborator

dgershman commented May 8, 2022

You can try out 4.0.5-beta1 which should fix this.

@dgershman
Copy link
Collaborator

Fixes Available in 4.1.0-beta2 if you want to test.

https://github.com/bmlt-enabled/yap/releases/tag/4.1.0-beta2

@dgershman
Copy link
Collaborator

fixes released in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants