sms for incoming calls customizable #636

RELEASENOTES.md

@@ -3,6 +3,7 @@
 ### 4.2.0 (UNRELEASED)
 * Yap now requires PHP version 8.0 and higher. [#623]
 * Added support for downloading the list of volunteers in JSON format for a given service body. [#612]
+* Added support for customizing SMS for incoming calls. [#636]
 * Show missed calls also as a percentage of total calls received.
 * Metric endpoint now returns volunteer missed and answered metrics, not exposed to UI yet. [#632]
 * Fixed an issue with reports not recursing more than one level. [#620]

lang/en-AU.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

lang/en-US.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

lang/es-US.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

lang/fr-CA.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

lang/it-IT.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

lang/pig-latin.php

@@ -97,3 +97,4 @@
 $GLOBALS['to_speak_to_a_man'] = "otay alktay otay ayay anmay";
 $GLOBALS['to_speak_to_a_woman'] = "otay alktay otay ayay omanway";
 $GLOBALS['speak_no_preference'] = "otay eakspay otay eitheryay";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "ouyay avehay anyay incomingyay onelinephay allcay omfray";

lang/pt-BR.php

@@ -105,3 +105,4 @@
 $GLOBALS['to_speak_to_a_man'] = "to talk to a man";
 $GLOBALS['to_speak_to_a_woman'] = "to talk to a woman";
 $GLOBALS['speak_no_preference'] = "to speak to either";
+$GLOBALS['you_have_an_incoming_phoneline_call_from'] = "You have an incoming phoneline call from";

legacy/_includes/functions.php

@@ -1682,7 +1682,7 @@ function getHelplineSchedule($service_body_int)
         $finalSchedule = getVolunteerInfo($volunteers);
 
         usort($finalSchedule, function ($a, $b) {
-            return $a->sequence > $b->sequence;
+            return $a->sequence > $b->sequence ? 1 : -1;
         });
 
         return json_encode($finalSchedule);
@@ -1743,7 +1743,7 @@ function get_str_val($subject)
         } else {
             return "false";
         }
-    } else if (is_array($subject)) {
+    } elseif (is_array($subject)) {
         return strval(json_encode($subject));
     }
 

legacy/helpline-dialer.php

@@ -84,7 +84,7 @@ function getCallConfig($serviceBodyCallHandling, $tandem = VolunteerShadowOption
 $conferences = $twilioClient->conferences->read(array ("friendlyName" => $_REQUEST['FriendlyName'] ));
 if (count($conferences) > 0 && $conferences[0]->status != "completed") {
     $tandem = 0;
-    $sms_body = "You have an incoming phoneline call from ";
+    $sms_body = word('you_have_an_incoming_phoneline_call_from') . " ";
     if (isset($_REQUEST['StatusCallbackEvent']) && $_REQUEST['StatusCallbackEvent'] == 'participant-join' &&
         ( isset($_REQUEST['SequenceNumber']) && intval($_REQUEST['SequenceNumber']) == 1 )) {
         setConferenceParticipant($_REQUEST['FriendlyName'], CallRole::CALLER);