🎨 Clean up and refactor to remove @codingStandardsIgnore annotation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 99.24% (diff: 100%)@@ master #52 diff @@
==========================================
Files 8 8
Lines 130 133 +3
Methods 25 25
Messages 0 0
Branches 0 0
==========================================
+ Hits 129 132 +3
Misses 1 1
Partials 0 0
|
|
Thanks @winkbrace ! |
|
@winkbrace if you are up for it I wonder if the same technique could be used here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed you had to ignore a part of the IndentationLevelSniff, so I took it upon me to refactor it a bit to get rid of the annotation.
I hope you're not unaccustomed with some functional programming 😅