Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CodeSniffRunner #14

Closed
bmitch opened this issue Dec 4, 2016 · 0 comments
Closed

Changes to CodeSniffRunner #14

bmitch opened this issue Dec 4, 2016 · 0 comments

Comments

@bmitch
Copy link
Owner

bmitch commented Dec 4, 2016

This class and the test classes could be cleaned up:

  • To get the error count and warning count you have to run the sniff twice. Should only have to do it once.
  • Can we get the error and warning message so that can be tested?

The code where it runs a sniff looks messy. Can this be cleaned up?

        $errorCount = $codeSnifferRunner->detectErrorCountInFileForSniff(
            __DIR__.'/Assets/FunctionLengthSniff/FunctionLengthSniff.inc',
            'Codor.Files.FunctionLength'
        );
@bmitch bmitch closed this as completed in 3593f33 Dec 4, 2016
bmitch added a commit that referenced this issue Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant