Merge pull request #32 from bmitch/redundant

Remove redundant code
bmitch · Dec 6, 2016 · 0886c4b · 0886c4b
2 parents 8160d5c + e3d5ed6
commit 0886c4b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/Codor/Sniffs/Files/ReturnNullSniff.php b/src/Codor/Sniffs/Files/ReturnNullSniff.php
@@ -31,17 +31,15 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
         $returnTokenIndex = $stackPtr;
 
         $returnValueToken = '';
-        for ($index = $returnTokenIndex; $index < count($tokens); $index++) {
+        $numberOfTokens = count($tokens);
+
+        for ($index = $returnTokenIndex; $index < $numberOfTokens; $index++) {
             if ($tokens[$index]['type'] === 'T_SEMICOLON') {
                 $returnValueToken = $tokens[$index - 1];
                 break;
             }
         }
 
-        if ($returnValueToken == '') {
-            return;
-        }
-
         if ($returnValueToken['type'] === 'T_NULL') {
             $error = "Return null value found.";
             $phpcsFile->addError($error, $stackPtr);