Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown-table for generating rules list #152

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

bmish
Copy link
Owner

@bmish bmish commented Oct 21, 2022

Eliminates need for us to manually create the table syntax.

Fixes a bug where we might end up with an extra space at the end of each table line (encountered in jsx-eslint/eslint-plugin-react#3469).

Ensures prettier will be able to format the table nicely due to the valid table syntax generated.

https://www.npmjs.com/package/markdown-table

@bmish bmish added the bug Something isn't working label Oct 21, 2022
@bmish bmish merged commit ccce381 into main Oct 21, 2022
@bmish bmish deleted the table-formatting branch October 21, 2022 13:57
@bmish bmish changed the title Use markdown-table for generating rules list Use markdown-table for generating rules list Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant