Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with svd merge int parameters handling #2464

Merged
merged 1 commit into from
May 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kohya_gui/svd_merge_lora_gui.py
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@ def add_model(model_path, ratio):
if not os.path.isfile(model_path):
log.info(f"The provided model at {model_path} is not a file")
return False
models.append(model_path)
models.append(fr"{model_path}")
ratios.append(str(ratio))
return True

@@ -89,7 +89,7 @@ def add_model(model_path, ratio):
run_cmd.extend(["--ratios"] + ratios)

run_cmd.extend(
["--device", device, "--new_rank", new_rank, "--new_conv_rank", new_conv_rank]
["--device", device, "--new_rank", str(new_rank), "--new_conv_rank", str(new_conv_rank)]
)

# Log the command

Unchanged files with check annotations Beta

## 謝辞
ControlNetの作者である lllyasviel 氏、実装上のアドバイスとトラブル解決へのご尽力をいただいた furusu 氏、ControlNetデータセットを実装していただいた ddPn08 氏に感謝いたします。

Check warning on line 203 in docs/train_lllite_README-ja.md

GitHub Actions / build

"Pn" should be "On".

Check warning on line 203 in docs/train_lllite_README-ja.md

GitHub Actions / build

"Pn" should be "On".
## サンプル
Canny
## Credit
I would like to thank lllyasviel, the author of ControlNet, furusu, who provided me with advice on implementation and helped me solve problems, and ddPn08, who implemented the ControlNet dataset.

Check warning on line 206 in docs/train_lllite_README.md

GitHub Actions / build

"Pn" should be "On".

Check warning on line 206 in docs/train_lllite_README.md

GitHub Actions / build

"Pn" should be "On".
## Sample