Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-editing for use-modern-adapter-syntax #1

Merged

Conversation

glittershark
Copy link

Minor copy-editing for the documentation changes in this branch.

@bmac
Copy link
Owner

bmac commented Mar 3, 2014

Awesome. Thanks.

bmac added a commit that referenced this pull request Mar 3, 2014
Copy-editing for use-modern-adapter-syntax
@bmac bmac merged commit 0a58b47 into bmac:use-modern-adapter-syntax Mar 3, 2014
@glittershark glittershark deleted the use-modern-adapter-syntax branch March 3, 2014 19:09
bmac pushed a commit that referenced this pull request Aug 20, 2015
[BUGFIX beta] Don't use old method names with the new injection system.
bmac pushed a commit that referenced this pull request May 20, 2019
* Fix lint error

* Fix `_requireBuildPackages` error

* Reset yarn.lock from master

There seems to be some issues in the yarn.lock

To solve them I ran:
- `git checkout master yarn.lock`
- `yarn`

Throw an error in case of dependency mismatch (#2)

* Throw an error in case of dependency mismatch

An app (or addon) that consumes ember-data should have:
- either jquery
- or ember-fetch version 6.0.0 or above

Throw a build error if it's not the case.

* Remove ember-fetch as a peerDependency

Move ember-fetch to dependencies (#3)

Indeed, two `ember-fetch`'s modules are imported in rest-adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants