-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Improve multiple components #142
Draft
selenil
wants to merge
3
commits into
bluzky:feature/accessibility-hook
Choose a base branch
from
selenil:feature/improve-multiple-components
base: feature/accessibility-hook
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP Improve multiple components #142
selenil
wants to merge
3
commits into
bluzky:feature/accessibility-hook
from
selenil:feature/improve-multiple-components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request improves the Sequence diagram for HoverCard interactionsequenceDiagram
actor User
participant HC as HoverCard
participant Zag as Zag.js
User->>HC: Hover over trigger
HC->>Zag: Trigger hover event
Zag->>HC: Calculate position
HC->>HC: Show content with animation
Note over HC: Position based on 'side' parameter
User->>HC: Move mouse away
HC->>HC: Hide content with animation
HC->>Zag: Emit on_open_change event
Class diagram for updated HoverCard and Tooltip componentsclassDiagram
class HoverCard {
+id: string
+open: boolean
+side: string
+options: map
+on_open: list
+class: string
+hover_card()
+hover_card_trigger()
+hover_card_content()
}
class Tooltip {
+id: string
+side: string
+options: map
+on_open: list
+class: string
+tooltip()
+tooltip_trigger()
+tooltip_content()
}
note for HoverCard "Added Zag.js integration
New positioning options
Improved configuration"
note for Tooltip "Added Zag.js integration
Enhanced positioning control"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features:
HoverCard
andTooltip
components for enhanced functionality and accessibility.