Support Zag collections

[selenil]

Summary by Sourcery

New Features:

• Add support for parsing and including Zag collections in the context.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR adds support for Zag collections by introducing a new parsing mechanism for collection data attributes in the ZagHook JavaScript module. The implementation extends the existing context building functionality to include collection data alongside options and listeners.

Class diagram for ZagHook.js with collection support

classDiagram
    class ZagHook {
        +parseOptions()
        +parseListeners()
        +parseCollection()
        +context()
    }
    note for ZagHook "parseCollection is a new method added to support Zag collections"
    ZagHook : parseCollection() returns collection
    ZagHook : context() includes collection

Loading

File-Level Changes

Change	Details	Files
Added collection data parsing functionality to the ZagHook context	Implemented new parseCollection method to handle collection data attributes Added camelCase key conversion for collection entries Integrated collection data into the context object alongside existing options and listeners Added error handling through the existing try-catch block	priv/static/assets/zag/ZagHook.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @selenil - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider removing the debug console.log statement for 'listeners' before finalizing this PR
• The error handling could be more robust - consider adding proper error reporting/handling mechanisms beyond console.error

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[bluzky]

Hi @selenil could you share the benefit of passing collection as a separated attribute vs passing in option?

[selenil]

Hi @selenil could you share the benefit of passing collection as a separated attribute vs passing in option?

I think that for complex collections, where a user may want to convert the label and value of any item, it would be cleaner to parse them separately instead of providing another option.

[bluzky]

Hi @selenil could you share the benefit of passing collection as a separated attribute vs passing in option?

I think that for complex collections, where a user may want to convert the label and value of any item, it would be cleaner to parse them separately instead of providing another option.

Currently, all options are passing via a single attribute instead of multiple attribute. In my opinion, it's not a big deal

[selenil]

Currently, all options are passing via a single attribute instead of multiple attribute. In my opinion, it's not a big deal

You're right, it would be better to pass all options through the data-option attribute. We should keep the prepare_collection helper since it doesn't rely on any data attribute.