Allow concatenation of different array strings #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Aug 17, 2024
| /// assert_eq!(&string[..], "ab"); | ||
| /// ``` | ||
| #[track_caller] | ||
| pub fn push_array_string<const OTHER_CAP: usize>(&mut self, other: ArrayString<OTHER_CAP>) { |
There was a problem hiding this comment.
The user should just use string.push_str(&a) here. Is there a reason not to do that?
There was a problem hiding this comment.
Ah would this work? I actually didn't know that! I assume this would also avoid heap allocs?
There was a problem hiding this comment.
of course, no heap allocations extra. ArrayString is just like another kind of String - they both have zero cost deref to &str.
There was a problem hiding this comment.
Ah perfect this can likely get closed out then!
There was a problem hiding this comment.
Ok, feel free to add an example that shows how this works, if you want to.
bluss
reviewed
Aug 17, 2024
|
Closing as the use case is already served by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user I would like to concat two
ArrayStringeasily. This exposes two methods to do this.