Codestyle wrongly assumes some strings are classes

[krzysztofrewak]

In one of our projects Codestyle wants to change this:

        if (in_array($response->status(), $this->handleByInertia, true)) {
            return Inertia::render("Error", [
                "status" => $response->status(),
            ])
                ->toResponse($request)
                ->setStatusCode($response->status());
        }

into:

        if (in_array($response->status(), $this->handleByInertia, true)) {
            return Inertia::render(\Error::class, [
                "status" => $response->status(),
            ])
                ->toResponse($request)
                ->setStatusCode($response->status());
        }

And this makes no sense at all. Other example:

            ["name" => "Redis"],

into:

            ["name" => \Redis::class],

We should handle this somehow.

[kamilpiech97]

I think, updating this if line with if in this fixer should help:

from:
if ($token->isGivenKind(T_CONSTANT_ENCAPSED_STRING))
to:
if ($token->isGivenKind(T_CONSTANT_ENCAPSED_STRING) && $token->getContent()[1] === "\\")

@krzysztofrewak
should we create our fixer or update in core?

[krzysztofrewak]

@kamilpiech97, you can try to open pull request in CS Fixer directly.

[krzysztofrewak]

@kamilpiech97, any updates?

[kamilpiech97]

Opened PR, we will see.
@krzysztofrewak

[krzysztofrewak]

@kamilpiech97, looks like you need to implement it on your way here.