-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name can contain non-ascii letters or space and long names must fit in the user context menu #1561
Comments
Hey @gorkem-bwl |
@yoyounik thanks for your interest in the project :) Please go ahead! |
@gorkem-bwl, i have made some changes in the PR : #1570 |
@yoyounik please read thoroughly and make sure you check those items as you send the PR: |
Yes @gorkem-bwl thanks for pointing it out :) |
@yoyounik I have added my comments there. Basically, you need a self review / testing of your code before sending a PR, together with a screenshot / video of how it works. |
Hii @gorkem-bwl i was working on the issue, but it is taking a time more than expected, can i be provided with some extra days to work on it? |
Yes, let me know in a couple of days where you are and we go from there. |
This check should be fixed so that name can contain space or diactric letters (e.g ç, ö, ğ).
Examples:
Also if a name is long, it must fit the user context menu by truncating:
The text was updated successfully, but these errors were encountered: