Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethinking external assets #270

Closed
wants to merge 56 commits into from
Closed

Rethinking external assets #270

wants to merge 56 commits into from

Conversation

evalott100
Copy link
Contributor

Closes #236

danielballan and others added 30 commits February 20, 2023 11:46
@danielballan @evalott100
Include importlib-metadata for 3.7.
c26bd32
@danielballan @evalott100
Update CI versions.
eba4dde
@danielballan @evalott100
Use importlib-metadata for 3.7.
04199c1
@danielballan @evalott100
Specify Python version as string to fix '3.10'.
5cbadf1
@danielballan @evalott100
Release notes for v1.19.1
a5dcd2d
@danielballan @evalott100
Fix typo.
2e526f5
@danielballan @evalott100
REL: v1.19.1
f33739f
@evalott100
Added TypedDicts to __init__.py and added the functionality and unit …
c53a2a8 
…tests for generating json schema from those TypedDicts
@evalott100
Merge branch 'master' into 235_add_typing_support_to_event_model
5a8ac5b
@evalott100
Fixed conflicts
114999f
@evalott100
Put extra schema in global dict using class decorator. Cleaned up in …
b746e19 
…general, working on typing everything to be mypy compliant
@evalott100
Found way to swap Annotated and Optional, not total=False classes req…
6801009 
…uired now. Two json contain an error where they are missing some details
@evalott100
Got schema generation working with single typeddict, without the need…
c75634f 
… to split them into total=False
@evalott100
Nearly finished typeddict conversion of __init__.py
46185b5
@evalott100
Finished schema generation and made __init__ mypy complient
cf5d39c
@evalott100
Massively simplified type parsing
fecb729
@evalott100
Converted sub typeddicts into basemodels recursively
21cbf8f
@evalott100
Merge branch 'master' into 235_add_typing_support_to_event_model
6c93708
@evalott100
Compatibility with the skeleton merge
7ad304e
@evalott100
Changed to get mypy CI working
b194445
@evalott100
Added precision and units to the event_descriptor
b6b59d0
@evalott100
Changed the workflow to add mypy to the linter
8b2d8bb
@evalott100
alphabetized the schema
a8d00b8
@evalott100
Added global patternProperties
48cb01b
@evalott100
Merge branch 'master' into 235_add_typing_support_to_event_model
86916ef
@evalott100
pulled from upstream
803a0b1
@evalott100
made mypy complient
b4810ff
@evalott100
Started creating the backwards compatible wrapper, I think it's a bet…
293e69d 
…ter idea to just add the compose_ functions manually. This commit is just so I can access what I've done for the wrapper in case I change my mind
@evalott100
wrote manual compose_ wrapper functions
7f2ce38
@evalott100
Started type hinting more fully, will come back to it
ce45fce
@evalott100
Redid the sorting of the schema
35cbcfd
@evalott100
Corrected mypy errors
c00da15
@evalott100
Merge branch 'master' into 235_add_typing_support_to_event_model
7db4bae
@evalott100
Fixed merge errors
32518ae
@evalott100
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
8ebf0b6 
…alott100/event-model into switch_from_partials_to_classes
@evalott100
Manually patch in top level additionalProperties: false
6f84dfc
@evalott100
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
d509a37 
…alott100/event-model into switch_from_partials_to_classes
@evalott100
Merge branch 'master' of github.com:evalott100/event-model into 235_a…
4fafc23 
…dd_typing_support_to_event_model
@evalott100
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
19830f0 
…alott100/event-model into switch_from_partials_to_classes
@evalott100
made compatible with new versioning
5c8d283
@evalott100
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
cdc49f4 
…alott100/event-model into switch_from_partials_to_classes
@evalott100
Changed the external assets, will need to do so for the bundler side too
952657e
@evalott100
Minor corrections in event_descriptor, datum_page, and run_start
b5ffe55
@evalott100
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
884bff4 
…alott100/event-model into switch_from_partials_to_classes
@evalott100
Merge branch 'switch_from_partials_to_classes' of github.com:evalott1…
3d560f0 
…00/event-model into rethinking_external_assets
@evalott100
Minor corrections in event_descriptor, datum_page, and run_start
582d7f3
@evalott100
Minor corrections in event_descriptor, datum_page, and run_start
2263b2a
@evalott100
Seperated out a PartialEvent and PartialResource from Event and Resource
19ed50e 
This seperation will enable the protocols to import the PartialDocs and for definitions to be more central.
@evalott100
ensure schema required list is sorted too
ebe579f
@evalott100
sorted required list (order is changed on this branch with the introd…
c96f31f 
…uction of PartialDoc parents
@evalott100 evalott100 requested a review from coretl May 25, 2023 09:50
@evalott100 evalott100 self-assigned this May 25, 2023
@evalott100 evalott100 marked this pull request as draft May 25, 2023 09:51
coretl
coretl reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll review this once the other 2 are merged, too difficult to review at the moment

@evalott100
Copy link
Contributor Author

Changing to #272

@evalott100 evalott100 closed this Jun 15, 2023
@evalott100 evalott100 deleted the rethinking_external_assets branch June 15, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl left review comments

Assignees

@evalott100 evalott100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethinking of external assets
3 participants
@evalott100 @coretl @danielballan