Skip to content

Tweak ProfileList design#7100

Merged
gaearon merged 4 commits into
mainfrom
tweak-lists
Dec 13, 2024
Merged

Tweak ProfileList design#7100
gaearon merged 4 commits into
mainfrom
tweak-lists

Conversation

@gaearon
Copy link
Copy Markdown
Contributor

@gaearon gaearon commented Dec 13, 2024

This makes List and Moderation List screens closer in design to the Starter Pack screen:

  • The description is moved inline into the header.
    • Also killed the "No description" label. If it has no description, it has no description, duh.
  • The "About" tab is now just called "People" (for Lists) because it is now just a list of people.
  • For mod lists, there's no tab header at all to avoid showing a single tab (which looked worse since Make the pager take full width #7066).

Review without whitespace

Test Plan

  • Check lists, mod lists, starter packs
  • Check lists with description and with no description
lists_up.mov
lists_up_web.mov

@arcalinea arcalinea temporarily deployed to tweak-lists - social-app PR #7100 December 13, 2024 21:08 — with Render Destroyed
<Animated.View
pointerEvents={isIOS ? 'auto' : 'box-none'}
style={[styles.tabBarMobile, headerTransform]}>
style={[styles.tabBarMobile, headerTransform, t.atoms.bg]}>
Copy link
Copy Markdown
Contributor Author

@gaearon gaearon Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was noticing scrollview content sometimes glitching appearing under the header, this makes the header always a solid color

@github-actions
Copy link
Copy Markdown
Contributor

Old size New size Diff
6.78 MB 6.78 MB -286 B (-0.00%)

Copy link
Copy Markdown
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@gaearon gaearon merged commit da6bcc5 into main Dec 13, 2024
@gaearon gaearon deleted the tweak-lists branch December 13, 2024 21:38
Signez pushed a commit to Signez/bsky-social-app that referenced this pull request Dec 26, 2024
* Remove "No description"

* Move Lists about into header

* Remove pager with one tab

* Layout tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants