Give minWidth to tab indicator only#7095
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
tweak-tabs - social-app PR #7095
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
Contributor
|
estrattonbailey
approved these changes
Dec 13, 2024
Member
estrattonbailey
left a comment
estrattonbailey
left a comment
There was a problem hiding this comment.
Test on web/ios, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7066 (comment)
Instead of giving min width to the tab item itself, instead give it to the indicator line. Also constrain it by the parent size so that it never extends beyond the tab item. As a result, the blue line will be 45px min, but won't inflate the tab bar item.
Test Plan
Verify "All" in notifications still has some extra minimum width.
Verify profile tab bar items are not inflated anymore.
web.mov
ios.mov