Cache Reanimated worklets#7068
Merged
Merged
Conversation
arcalinea
temporarily deployed
to
cache-worklets - social-app PR #7068
Render
Destroyed
gaearon
requested review from
estrattonbailey,
haileyok,
mozzius and
pfrazee
haileyok
approved these changes
Dec 12, 2024
Contributor
|
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* Undo perf hackfix * Bump Reanimated to include software-mansion/react-native-reanimated#6758 * Bump to 3.17.0-nightly-20241211-17e89ca24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Reanimated to a version with software-mansion/react-native-reanimated#6758.
Also reverts my hackfix from #6219.
Test Plan
This will need some walking around the app etc. Let's put it on TF to see better.
I verified that reverting the hackfix did not hurt with the bump (but would hurt without the bump). In other words, this actually does fix the original problem described in #6219.
So this probably improves perf in other places too.