New profile feed header#7056
Merged
Merged
Conversation
This reverts commit f58a7fa.
arcalinea
temporarily deployed
to
new-profile-feed-header - social-app PR #7056
Render
Destroyed
Contributor
|
surfdude29
reviewed
Dec 11, 2024
Contributor
surfdude29
left a comment
surfdude29
left a comment
There was a problem hiding this comment.
A couple of tiny suggestions 👀
| <View | ||
| style={[a.flex_row, a.align_center, a.gap_sm, a.justify_between]}> | ||
| <Text style={[a.italic, t.atoms.text_contrast_medium]}> | ||
| Something wrong? Let us know. |
Contributor
There was a problem hiding this comment.
Suggested change
| Something wrong? Let us know. | |
| <Trans>Something wrong? Let us know.</Trans> |
Contributor
There was a problem hiding this comment.
Also, just wondering, will the text be able to wrap onto another line here at larger text sizes and in non-English localizations?
surfdude29
reviewed
Dec 11, 2024
| <Text | ||
| style={[a.text_sm, a.leading_tight, t.atoms.text_contrast_medium]} | ||
| numberOfLines={1}> | ||
| <Trans>By</Trans>{' '} |
Contributor
There was a problem hiding this comment.
Also, I'm wondering if it might be desirable (or indeed feasible) to restructure this, so that By and the handle are both in the string to be translated, for languages where some flexibility is needed? 🤔
Contributor
There was a problem hiding this comment.
Yes, Trans should be pulled outside here
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
arcalinea
temporarily deployed
to
new-profile-feed-header - social-app PR #7056
Render
Destroyed
arcalinea
temporarily deployed
to
new-profile-feed-header - social-app PR #7056
Render
Destroyed
gaearon
approved these changes
Dec 12, 2024
arcalinea
temporarily deployed
to
new-profile-feed-header - social-app PR #7056
Render
Destroyed
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
* Init hacking * Lil baby button checkpoint * Playing around * Revert "Playing around" This reverts commit f58a7fa. * Mostly there * Cleanups * Cleanup * Fix report dialog nesting * Remove transform on native * Rename header * Fix layout, overflowing FAB buttons * Remove hack * Couple of fixes * Keep Pin primary CTA (bluesky-social#7061) * Update src/screens/Profile/components/ProfileFeedHeader.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * Simplify, use old string * Wrap Trans better --------- Co-authored-by: dan <dan.abramov@gmail.com> Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Medium-sized step towards some cleaner UI for this screen. More work will be done here.
This PR aims to keep translation strings mostly the same, but some were added.