Trim back prefs exposure in NUXs, make naming more friendly #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
nux-updates - social-app PR #6980
Render
Destroyed
|
gaearon
approved these changes
Dec 6, 2024
estrattonbailey
added a commit
that referenced
this pull request
Dec 8, 2024
* origin/main: Revert "[Video] Revert safari hackfix (#5367)" (#7001) Fix squashed content on mod screens (#7004) [ELI5] Change feed page copy (#6932) Immediately parse pre-filled links in composer state (#6974) Add useFormatCurrency hook (#6978) Update view shot (#6995) Remove icon (#6994) clean rn 0.76 upgrade (#6887) Trim back prefs exposure in NUXs, make naming more friendly (#6980) [Layout] Base (#6907) Add some icons (#6976)
estrattonbailey
added a commit
that referenced
this pull request
Dec 10, 2024
…con-screen * origin/main: Access content of extended block properly (block.Super instead of super()) (#7026) Add `isSelfHosted` to `SessionAccount` (#7028) Add back button to desktop threads (#7010) Revert "[Video] Revert safari hackfix (#5367)" (#7001) Fix squashed content on mod screens (#7004) [ELI5] Change feed page copy (#6932) Immediately parse pre-filled links in composer state (#6974) Add useFormatCurrency hook (#6978) Update view shot (#6995) Remove icon (#6994) clean rn 0.76 upgrade (#6887) Trim back prefs exposure in NUXs, make naming more friendly (#6980) [Layout] Base (#6907) Add some icons (#6976)
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No NUXs are in use atm, so this doesn't affect anything, but when implementing some new ones, I realized we were passing around all of the user's preferences state uneccessarily. Plus, "reset" and "save" are more easily understandable terms for the end-user contract. The API methods use more technical terms, but these work better here.