Add Khmer Localization#6914
Conversation
|
This will be close (#6897) |
|
It's always great to see another localization for Bluesky! 🦋🌐 Would it be possible to make three more changes in this PR to fully enable the Khmer localization please:
|
|
Also, the devs ask for localisation PRs to be reviewed by at least one other native speaker; is there someone you could ask to do that? They don't necessarily have to have a GitHub account :) @/pfrazee said this about the initial review on another localization PR:
|
|
|
||
| #: src/view/screens/Settings/index.tsx:455 | ||
| #~ msgid "Accessibility settings" | ||
| #~ msgstr "ការកំណត់ភាពងាយស្រួល" |
There was a problem hiding this comment.
Also, one tip for the future: the lines starting with #~ are obsolete strings that are no longer used in the app, so you can safely ignore them and there's no need to translate them. Some translators like to remove them to keep things tidy, but there's no need to do this if you'd prefer not to as they'll simply be ignored by the app.
|
@surfdude29 Thank you for reviewing my PR. Now I have added the missing key. |
|
|
||
| #: src/Navigation.tsx:322 | ||
| msgid "Accessibility Settings" | ||
| msgstr "ការកំណត់ភាពងាយស្រួល" |
There was a problem hiding this comment.
Accessibility Settings would be better if translated to ការកំណត់មានភាពងាយស្រួល
There was a problem hiding this comment.
A friendly tip in case it's helpful: you can suggest an alternate translation by clicking the ± button and then filling it in, e.g. like this:
| msgstr "ការកំណត់ភាពងាយស្រួល" | |
| msgstr "(suggested translation)" |
If the PR author wants to accept the suggestion as it is, it's very easy for them to do so, and they can even accept many suggestions at once in a batch 💫
|
|
||
| #: src/view/com/profile/ProfileMenu.tsx:108 | ||
| msgid "Account muted" | ||
| msgstr "គណនីត្រូវបានបិទ" |
There was a problem hiding this comment.
Mute is different from Close and Block so I don't think the same translates as បិទ it's should be:
Mute = បិទសម្លេង
Block = បញ្ឈប់
There was a problem hiding this comment.
So what would you suggest about Account muted in khmer?
|
@SokCheasrouch I really appreciate your time and effort in helping me out. Please confirm if you're done with review. And everything should be ready to go🚀 |
|
@roth-dev I have just done my review |
|
@surfdude29 All done |
|
All updated according to sugesstion. |
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
* add khmer language * update translate * update translate * add missing localization key * update khmer wording * update khmer wording * add missing translate * add missing translate * chore: add khmer local date-time format * Update src/locale/i18n.ts Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com> Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
4 participants
No description provided.